]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
drm/amd/display: Add null check in resource_log_pipe_topology_update
authorNatanel Roizenman <natanel.roizenman@amd.com>
Wed, 3 Apr 2024 20:52:48 +0000 (16:52 -0400)
committerAlex Deucher <alexander.deucher@amd.com>
Tue, 30 Apr 2024 13:45:33 +0000 (09:45 -0400)
[WHY]
When switching from "Extend" to "Second Display Only" we sometimes
call resource_get_otg_master_for_stream on a stream for the eDP,
which is disconnected. This leads to a null pointer dereference.

[HOW]
Added a null check in dc_resource.c/resource_log_pipe_topology_update.

CC: stable@vger.kernel.org
Reviewed-by: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>
Acked-by: Aurabindo Pillai <aurabindo.pillai@amd.com>
Signed-off-by: Natanel Roizenman <natanel.roizenman@amd.com>
Tested-by: Daniel Wheeler <daniel.wheeler@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/display/dc/core/dc_resource.c

index 6831b01517059f63d7004a047c2276735272b8ed..bb43c62e959a496b2cb568919b988742c5b1c7b1 100644 (file)
@@ -2302,6 +2302,10 @@ void resource_log_pipe_topology_update(struct dc *dc, struct dc_state *state)
 
                otg_master = resource_get_otg_master_for_stream(
                                &state->res_ctx, state->streams[stream_idx]);
+
+               if (!otg_master)
+                       continue;
+
                resource_log_pipe_for_stream(dc, state, otg_master, stream_idx);
        }
        if (state->phantom_stream_count > 0) {