ovl: drop ovl_setup_cred_for_create()

It is now unused and can be removed.

Link: https://patch.msgid.link/20251117-work-ovl-cred-guard-prepare-v2-6-bd1c97a36d7b@kernel.org
Reviewed-by: Amir Goldstein <amir73il@gmail.com>
Signed-off-by: Christian Brauner <brauner@kernel.org>

diff --git a/fs/overlayfs/dir.c b/fs/overlayfs/dir.c
index 6cfa7857b3524dd2aab4782e5955a4f6bbc44373..0f01e005b915b3fc5b0c8dde7e8b00e243451b02 100644 (file)
--- a/fs/overlayfs/dir.c
+++ b/fs/overlayfs/dir.c
@@ -617,39 +617,6 @@ DEFINE_CLASS(ovl_override_creator_creds,
             ovl_override_creator_creds(dentry, inode, mode),
             struct dentry *dentry, struct inode *inode, umode_t mode)
 
-static const __maybe_unused struct cred *ovl_setup_cred_for_create(struct dentry *dentry,
-                                                   struct inode *inode,
-                                                   umode_t mode,
-                                                   const struct cred *old_cred)
-{
-       int err;
-       struct cred *override_cred;
-
-       override_cred = prepare_creds();
-       if (!override_cred)
-               return ERR_PTR(-ENOMEM);
-
-       override_cred->fsuid = inode->i_uid;
-       override_cred->fsgid = inode->i_gid;
-       err = security_dentry_create_files_as(dentry, mode, &dentry->d_name,
-                                             old_cred, override_cred);
-       if (err) {
-               put_cred(override_cred);
-               return ERR_PTR(err);
-       }
-
-       /*
-        * Caller is going to match this with revert_creds() and drop
-        * referenec on the returned creds.
-        * We must be called with creator creds already, otherwise we risk
-        * leaking creds.
-        */
-       old_cred = override_creds(override_cred);
-       WARN_ON_ONCE(old_cred != ovl_creds(dentry->d_sb));
-
-       return override_cred;
-}
-
 static int ovl_create_handle_whiteouts(struct dentry *dentry,
                                       struct inode *inode,
                                       struct ovl_cattr *attr)