+2006-01-28 Zack Weinberg <zackw@panix.com>
+
+ * c.opt: Add -W(no-)overlength-strings.
+ * doc/invoke.texi: Document it.
+ * c-opts.c (c_common_handle_option): -pedantic implies
+ -Woverlength-strings, if not explicitly disabled already.
+ (c_common_post_options): -Woverlength-strings defaults to off, and
+ is always off for C++.
+ * c-common.c (fix_string_type): Issue warning about strings longer
+ than is portable only if warn_overlength_strings. Rearrange code
+ a little for clarity.
+ * configure.in: Check for -Wno-overlength-strings as well before
+ enabling -pedantic in stage 1.
+ * Makefile.in (STRICT2_WARN): Add -Wno-overlength-strings.
+ (gcc.o-warn, insn-automata.o-warn, build/gencondmd.o-warn): Delete.
+
+ * genconditions.c (write_header, write_one_condition)
+ (write_conditions, write_writer): Consolidate very long strings
+ that were broken up to fit in C89 portable limit. Don't use
+ printf when fputs will do.
+
2006-01-28 Adam Nemet <anemet@caviumnetworks.com>
* combine.c (simplify_comparison <AND>): Check
TRULY_NOOP_TRUNCATION before start using a subreg.
-
- * config/mips/mips.md (*branch_zero<mode>,
- *branch_zero<mode>_inverted, *branch_equality<mode>,
- *branch_equality<mode>_inverted, *branch_equality<mode>_mips16):
- Remove mode check from comparisons.
+
+ * config/mips/mips.md (*branch_zero<mode>,
+ *branch_zero<mode>_inverted, *branch_equality<mode>,
+ *branch_equality<mode>_inverted, *branch_equality<mode>_mips16):
+ Remove mode check from comparisons.
2006-01-28 Kenneth Zadeck <zadeck@naturalbridge.com>
2006-01-27 Daniel Berlin <dberlin@dberlin.org>
Kenneth Zadeck <zadeck@naturalbridge.com>
- PR rtl-optimization/24762
+ PR rtl-optimization/24762
* doc/tm.texi: Added TARGET_EXTRA_LIVE_ON_ENTRY.
* targhooks.c (hook_void_bitmap): New hook prototype.
* targhoohs.h (hook_void_bitmap): Ditto.
STRICT_WARN = @strict1_warn@
WERROR_FLAGS = @WERROR@
STRICT2_WARN = -pedantic -Wno-long-long -Wno-variadic-macros \
- -Wold-style-definition -Wmissing-format-attribute $(WERROR_FLAGS)
+ -Wno-overlength-strings -Wold-style-definition -Wmissing-format-attribute \
+ $(WERROR_FLAGS)
# This is set by --enable-checking. The idea is to catch forgotten
# "extern" tags in header files.
build-warn = $(STRICT_WARN)
GCC_WARN_CFLAGS = $(LOOSE_WARN) $($(@D)-warn) $(NOCOMMON_FLAG) $($@-warn)
-# These files are to have -Werror bypassed in stage2:
-# These are very hard to completely clean due to target complexities.
-gcc.o-warn = -Wno-error
-insn-automata.o-warn = -Wno-error
-build/gencondmd.o-warn = -Wno-error
+# These files are to have specific diagnostics suppressed, or are not to
+# be subject to -Werror:
# Bison-1.75 output often yields (harmless) -Wtraditional warnings
build/gengtype-yacc.o-warn = -Wno-error
# flex output may yield harmless "no previous prototype" warnings
{
const int wchar_bytes = TYPE_PRECISION (wchar_type_node) / BITS_PER_UNIT;
const int wide_flag = TREE_TYPE (value) == wchar_array_type_node;
- const int nchars_max = flag_isoc99 ? 4095 : 509;
int length = TREE_STRING_LENGTH (value);
int nchars;
tree e_type, i_type, a_type;
/* Compute the number of elements, for the array type. */
nchars = wide_flag ? length / wchar_bytes : length;
- if (pedantic && nchars - 1 > nchars_max && !c_dialect_cxx ())
- pedwarn ("string length %qd is greater than the length %qd ISO C%d compilers are required to support",
- nchars - 1, nchars_max, flag_isoc99 ? 99 : 89);
+ /* C89 2.2.4.1, C99 5.2.4.1 (Translation limits). The analogous
+ limit in C++98 Annex B is very large (65536) and is not normative,
+ so we do not diagnose it (warn_overlength_strings is forced off
+ in c_common_post_options). */
+ if (warn_overlength_strings)
+ {
+ const int nchars_max = flag_isoc99 ? 4095 : 509;
+ const int relevant_std = flag_isoc99 ? 99 : 90;
+ if (nchars - 1 > nchars_max)
+ /* Translators: The %d after 'ISO C' will be 90 or 99. Do not
+ separate the %d from the 'C'. 'ISO' should not be
+ translated, but it may be moved after 'C%d' in languages
+ where modifiers follow nouns. */
+ pedwarn ("string length %qd is greater than the length %qd "
+ "ISO C%d compilers are required to support",
+ nchars - 1, nchars_max, relevant_std);
+ }
- e_type = wide_flag ? wchar_type_node : char_type_node;
/* Create the array type for the string constant. flag_const_strings
says make the string constant an array of const char so that
copying it to a non-const pointer will get a warning. For C++,
construct the matching unqualified array type first. The C front
end does not require this, but it does no harm, so we do it
unconditionally. */
+ e_type = wide_flag ? wchar_type_node : char_type_node;
i_type = build_index_type (build_int_cst (NULL_TREE, nchars - 1));
a_type = build_array_type (e_type, i_type);
if (flag_const_strings)
cpp_opts->warn_endif_labels = 1;
if (warn_pointer_sign == -1)
warn_pointer_sign = 1;
+ if (warn_overlength_strings == -1)
+ warn_overlength_strings = 1;
break;
case OPT_print_objc_runtime_info:
if (warn_pointer_sign == -1)
warn_pointer_sign = 0;
+ /* -Woverlength-strings is off by default, but is enabled by -pedantic.
+ It is never enabled in C++, as the minimum limit is not normative
+ in that standard. */
+ if (warn_overlength_strings == -1 || c_dialect_cxx ())
+ warn_overlength_strings = 0;
+
/* Special format checking options don't work without -Wformat; warn if
they are used. */
if (!warn_format)
C ObjC Var(warn_old_style_definition)
Warn if an old-style parameter definition is used
+Woverlength-strings
+C ObjC C++ ObjC++ Var(warn_overlength_strings) Init(-1)
+Warn if a string is longer than the maximum portable length specified by the standard
+
Woverloaded-virtual
C++ ObjC++ Var(warn_overloaded_virtual)
Warn about overloaded virtual function names
# We want to use -pedantic, but we don't want warnings about
# * 'long long'
# * variadic macros
+# * overlong strings
# So, we only use -pedantic if we can disable those warnings.
echo "$as_me:$LINENO: checking whether ${CC} accepts -Wno-long-long" >&5
echo "$as_me:$LINENO: result: $ac_cv_prog_cc_w_no_variadic_macros" >&5
echo "${ECHO_T}$ac_cv_prog_cc_w_no_variadic_macros" >&6
+echo "$as_me:$LINENO: checking whether ${CC} accepts -Wno-overlength-strings" >&5
+echo $ECHO_N "checking whether ${CC} accepts -Wno-overlength-strings... $ECHO_C" >&6
+if test "${ac_cv_prog_cc_w_no_overlength_strings+set}" = set; then
+ echo $ECHO_N "(cached) $ECHO_C" >&6
+else
+ save_CFLAGS="$CFLAGS"
+ CFLAGS="-Wno-overlength-strings"
+ cat >conftest.$ac_ext <<_ACEOF
+/* confdefs.h. */
+_ACEOF
+cat confdefs.h >>conftest.$ac_ext
+cat >>conftest.$ac_ext <<_ACEOF
+/* end confdefs.h. */
+
+_ACEOF
+rm -f conftest.$ac_objext
+if { (eval echo "$as_me:$LINENO: \"$ac_compile\"") >&5
+ (eval $ac_compile) 2>conftest.er1
+ ac_status=$?
+ grep -v '^ *+' conftest.er1 >conftest.err
+ rm -f conftest.er1
+ cat conftest.err >&5
+ echo "$as_me:$LINENO: \$? = $ac_status" >&5
+ (exit $ac_status); } &&
+ { ac_try='test -z "$ac_c_werror_flag" || test ! -s conftest.err'
+ { (eval echo "$as_me:$LINENO: \"$ac_try\"") >&5
+ (eval $ac_try) 2>&5
+ ac_status=$?
+ echo "$as_me:$LINENO: \$? = $ac_status" >&5
+ (exit $ac_status); }; } &&
+ { ac_try='test -s conftest.$ac_objext'
+ { (eval echo "$as_me:$LINENO: \"$ac_try\"") >&5
+ (eval $ac_try) 2>&5
+ ac_status=$?
+ echo "$as_me:$LINENO: \$? = $ac_status" >&5
+ (exit $ac_status); }; }; then
+ ac_cv_prog_cc_w_no_overlength_strings=yes
+else
+ echo "$as_me: failed program was:" >&5
+sed 's/^/| /' conftest.$ac_ext >&5
+
+ac_cv_prog_cc_w_no_overlength_strings=no
+fi
+rm -f conftest.err conftest.$ac_objext conftest.$ac_ext
+ CFLAGS="$save_CFLAGS"
+
+fi
+echo "$as_me:$LINENO: result: $ac_cv_prog_cc_w_no_overlength_strings" >&5
+echo "${ECHO_T}$ac_cv_prog_cc_w_no_overlength_strings" >&6
+
strict1_warn=
if test $ac_cv_prog_cc_w_no_long_long = yes \
- && test $ac_cv_prog_cc_w_no_variadic_macros = yes ; then
- strict1_warn="-pedantic -Wno-long-long -Wno-variadic-macros"
+ && test $ac_cv_prog_cc_w_no_variadic_macros = yes \
+ && test $ac_cv_prog_cc_w_no_overlength_strings = yes ; then
+ strict1_warn="-pedantic -Wno-long-long -Wno-variadic-macros -Wno-overlength-strings"
fi
# Add -Wold-style-definition if it's accepted
else
ac_prog_version=`$MAKEINFO --version 2>&1 |
sed -n 's/^.*GNU texinfo.* \([0-9][0-9.]*\).*$/\1/p'`
- echo "configure:7471: version of makeinfo is $ac_prog_version" >&5
+ echo "configure:7523: version of makeinfo is $ac_prog_version" >&5
case $ac_prog_version in
'') gcc_cv_prog_makeinfo_modern=no;;
4.[4-9]*)
# We want to use -pedantic, but we don't want warnings about
# * 'long long'
# * variadic macros
+# * overlong strings
# So, we only use -pedantic if we can disable those warnings.
AC_CACHE_CHECK(
CFLAGS="$save_CFLAGS"
])
+AC_CACHE_CHECK(
+ [whether ${CC} accepts -Wno-overlength-strings],
+ [ac_cv_prog_cc_w_no_overlength_strings],
+ [save_CFLAGS="$CFLAGS"
+ CFLAGS="-Wno-overlength-strings"
+ AC_COMPILE_IFELSE([AC_LANG_SOURCE([[]])],
+ [ac_cv_prog_cc_w_no_overlength_strings=yes],
+ [ac_cv_prog_cc_w_no_overlength_strings=no])
+ CFLAGS="$save_CFLAGS"
+ ])
+
strict1_warn=
if test $ac_cv_prog_cc_w_no_long_long = yes \
- && test $ac_cv_prog_cc_w_no_variadic_macros = yes ; then
- strict1_warn="-pedantic -Wno-long-long -Wno-variadic-macros"
+ && test $ac_cv_prog_cc_w_no_variadic_macros = yes \
+ && test $ac_cv_prog_cc_w_no_overlength_strings = yes ; then
+ strict1_warn="-pedantic -Wno-long-long -Wno-variadic-macros -Wno-overlength-strings"
fi
# Add -Wold-style-definition if it's accepted
-Wmain -Wmissing-braces -Wmissing-field-initializers @gol
-Wmissing-format-attribute -Wmissing-include-dirs @gol
-Wmissing-noreturn @gol
--Wno-multichar -Wnonnull -Wpacked -Wpadded @gol
+-Wno-multichar -Wnonnull -Woverlength-strings -Wpacked -Wpadded @gol
-Wparentheses -Wpointer-arith -Wno-pointer-to-int-cast @gol
-Wredundant-decls @gol
-Wreturn-type -Wsequence-point -Wshadow @gol
Usually these warnings alert that the programmer intended to use
@code{strcmp}. This warning is enabled by @option{-Wall}.
+@item -Woverlength-strings
+@opindex Woverlength-strings
+Warn about string constants which are longer than the ``minimum
+maximum'' length specified in the C standard. Modern compilers
+generally allow string constants which are much longer than the
+standard's minimum limit, but very portable programs should avoid
+using longer strings.
+
+The limit applies @emph{after} string constant concatenation, and does
+not count the trailing NUL@. In C89, the limit was 509 characters; in
+C99, it was raised to 4095. C++98 does not specify a normative
+minimum maximum, so we do not diagnose overlength strings in C++@.
+
+This option is implied by @option{-pedantic}, and can be disabled with
+@option{-Wno-overlength-strings}.
@end table
@node Debugging Options
machine description file. */\n\
\n\
#include \"bconfig.h\"\n\
-#include \"system.h\"\n");
-
- puts ("\
+#include \"system.h\"\n\
+\n\
/* It is necessary, but not entirely safe, to include the headers below\n\
in a generator program. As a defensive measure, don't do so when the\n\
table isn't going to have anything in it. */\n\
#undef ENABLE_RTL_CHECKING\n\
#undef ENABLE_RTL_FLAG_CHECKING\n\
#undef ENABLE_GC_CHECKING\n\
-#undef ENABLE_GC_ALWAYS_COLLECT\n");
-
- puts ("\
+#undef ENABLE_GC_ALWAYS_COLLECT\n\
+\n\
#include \"coretypes.h\"\n\
#include \"tm.h\"\n\
#include \"insn-constants.h\"\n\
#include \"rtl.h\"\n\
#include \"tm_p.h\"\n\
-#include \"function.h\"\n");
-
- puts ("\
+#include \"function.h\"\n\
+\n\
/* Fake - insn-config.h doesn't exist yet. */\n\
#define MAX_RECOG_OPERANDS 10\n\
#define MAX_DUP_OPERANDS 10\n\
-#define MAX_INSNS_PER_SPLIT 5\n");
-
- puts ("\
+#define MAX_INSNS_PER_SPLIT 5\n\
+\n\
#include \"regs.h\"\n\
#include \"recog.h\"\n\
#include \"real.h\"\n\
putchar (*p);
}
- printf ("\",\n __builtin_constant_p ");
+ fputs ("\",\n __builtin_constant_p ", stdout);
print_c_condition (test->expr);
- printf ("\n ? (int) ");
+ fputs ("\n ? (int) ", stdout);
print_c_condition (test->expr);
- printf ("\n : -1 },\n");
+ fputs ("\n : -1 },\n", stdout);
return 1;
}
{\n\
const char *expr;\n\
int value;\n\
-};\n");
-
- puts ("\
+};\n\
+\n\
/* This table lists each condition found in the machine description.\n\
Each condition is mapped to its truth value (0 or 1), or -1 if that\n\
cannot be calculated at compile time.\n\
" putchar (*p);\n"
" }\n"
" puts (\"\\\")\");\n"
- " }");
- puts (" puts (\"])\");\n"
+ " }\n"
+ " puts (\"])\");\n"
" fflush (stdout);\n"
"return ferror (stdout) != 0 ? FATAL_EXIT_CODE : SUCCESS_EXIT_CODE;\n"
"}");
+2006-01-28 Zack Weinberg <zackw@panix.com>
+
+ * gcc.dg/Woverlength-strings.c
+ * gcc.dg/Woverlength-strings-pedantic-c89.c
+ * gcc.dg/Woverlength-strings-pedantic-c89-no.c
+ * gcc.dg/Woverlength-strings-pedantic-c99.c
+ * gcc.dg/Woverlength-strings-pedantic-c99-no.c: New tests.
+
2006-01-28 Adam Nemet <anemet@caviumnetworks.com>
- * gcc.c-torture/execute/20060127-1.c: New test.
+ * gcc.c-torture/execute/20060127-1.c: New test.
2006-01-28 Mark Mitchell <mark@codesourcery.com>
2006-01-26 Laurent GUERBY <laurent@guerby.net>
- PR ada/21317
- * ada/acats/support/impdef.a: Add One_Long_Second.
- * ada/acats/tests/c9/c94025.a: Use One_Long_Second.
- * ada/acats/tests/c9/c94026.a: Likewise.
- * ada/acats/tests/c9/c97305c.ada: Likewise.
- * ada/acats/tests/c9/c99004a.ada: Likewise.
+ PR ada/21317
+ * ada/acats/support/impdef.a: Add One_Long_Second.
+ * ada/acats/tests/c9/c94025.a: Use One_Long_Second.
+ * ada/acats/tests/c9/c94026.a: Likewise.
+ * ada/acats/tests/c9/c97305c.ada: Likewise.
+ * ada/acats/tests/c9/c99004a.ada: Likewise.
2005-01-26 Paul Thomas <pault@gcc.gnu.org>
PR C/25861
* gcc.c-torture/compile/pr25861.c: New test.
-
+
2006-01-26 Paul Brook <paul@codesourcery.com>
* gcc.dg/compat/struct-layout-1.exp: Pass -e to generator program
* gfortran.dg/read_eof_1.f90: Rename from read_eof.f90.
* gfortran.dg/read_eof_2.f90: New test.
* gfortran.dg/read_eof_3.f90: New test.
-
+
2006-01-24 Andrew Pinski <pinskia@physics.uc.edu>
PR tree-opt/25860
2006-01-20 Dirk Mueller <dmueller@suse.com>
- PR c++/5520
- * g++.dg/warn/empty-body.C: New.
+ PR c++/5520
+ * g++.dg/warn/empty-body.C: New.
2006-01-19 Mark Mitchell <mark@codesourcery.com>
to LD_LIBRARY_PATH.
2006-01-16 Eric Botcazou <ebotcazou@adacore.com>
-
Andrew Pinski <pinskia@physics.uc.edu>
+ Andrew Pinski <pinskia@physics.uc.edu>
* gcc.dg/minmax-1.c: New test.
2006-01-11 Paolo Bonzini <bonzini@gnu.org>
- PR tree-optimization/23109
- PR tree-optimization/23948
- PR tree-optimization/24123
+ PR tree-optimization/23109
+ PR tree-optimization/23948
+ PR tree-optimization/24123
- * gcc.dg/tree-ssa/recip-3.c, gcc.dg/tree-ssa/recip-4.c,
- gcc.dg/tree-ssa/recip-5.c, gcc.dg/tree-ssa/recip-6.c,
- gcc.dg/tree-ssa/recip-7.c, gcc.dg/tree-ssa/pr23109.c,
- g++.dg/tree-ssa/pr23948.C: New testcases.
- * gcc.dg/tree-ssa/recip-2.c, gcc.dg/tree-ssa/pr23234.c: Provide
+ * gcc.dg/tree-ssa/recip-3.c, gcc.dg/tree-ssa/recip-4.c,
+ gcc.dg/tree-ssa/recip-5.c, gcc.dg/tree-ssa/recip-6.c,
+ gcc.dg/tree-ssa/recip-7.c, gcc.dg/tree-ssa/pr23109.c,
+ g++.dg/tree-ssa/pr23948.C: New testcases.
+ * gcc.dg/tree-ssa/recip-2.c, gcc.dg/tree-ssa/pr23234.c: Provide
three divisions in order to do the optimization.
2006-01-11 Zdenek Dvorak <dvorakz@suse.cz>
--- /dev/null
+/* -Woverlength-strings complains about string constants which are too long
+ for the C standard's "minimum maximum" limits. It is off by default,
+ but implied by -pedantic. */
+
+/* { dg-options "-std=c89 -pedantic -Wno-overlength-strings" } */
+
+#define TEN "xxxxxxxxxx"
+#define HUN TEN TEN TEN TEN TEN TEN TEN TEN TEN TEN
+#define THO HUN HUN HUN HUN HUN HUN HUN HUN HUN HUN
+
+/* C89's minimum-maximum is 509. */
+const char x510[] = HUN HUN HUN HUN HUN TEN;
+
+/* C99's minimum-maximum is 4095. */
+const char x4096[] =
+ THO THO THO THO /* 4000 */
+ TEN TEN TEN TEN TEN /* 4050 */
+ TEN TEN TEN TEN /* 4090 */
+ "123456";
--- /dev/null
+/* -Woverlength-strings complains about string constants which are too long
+ for the C standard's "minimum maximum" limits. It is off by default,
+ but implied by -pedantic. */
+
+/* { dg-options "-std=c89 -pedantic" } */
+
+#define TEN "xxxxxxxxxx"
+#define HUN TEN TEN TEN TEN TEN TEN TEN TEN TEN TEN
+#define THO HUN HUN HUN HUN HUN HUN HUN HUN HUN HUN
+
+/* C89's minimum-maximum is 509. */
+const char x510[] = HUN HUN HUN HUN HUN TEN; /* { dg-warning "greater than" } */
+
+/* C99's minimum-maximum is 4095. */
+const char x4096[] =
+ THO THO THO THO /* 4000 */
+ TEN TEN TEN TEN TEN /* 4050 */
+ TEN TEN TEN TEN /* 4090 */
+ "123456"; /* { dg-warning "greater than" } */
--- /dev/null
+/* -Woverlength-strings complains about string constants which are too long
+ for the C standard's "minimum maximum" limits. It is off by default,
+ but implied by -pedantic. */
+
+/* { dg-options "-std=c99 -pedantic -Wno-overlength-strings" } */
+
+#define TEN "xxxxxxxxxx"
+#define HUN TEN TEN TEN TEN TEN TEN TEN TEN TEN TEN
+#define THO HUN HUN HUN HUN HUN HUN HUN HUN HUN HUN
+
+/* C89's minimum-maximum is 509. */
+const char x510[] = HUN HUN HUN HUN HUN TEN;
+
+/* C99's minimum-maximum is 4095. */
+const char x4096[] =
+ THO THO THO THO /* 4000 */
+ TEN TEN TEN TEN TEN /* 4050 */
+ TEN TEN TEN TEN /* 4090 */
+ "123456";
--- /dev/null
+/* -Woverlength-strings complains about string constants which are too long
+ for the C standard's "minimum maximum" limits. It is off by default,
+ but implied by -pedantic. */
+
+/* { dg-options "-std=c99 -pedantic" } */
+
+#define TEN "xxxxxxxxxx"
+#define HUN TEN TEN TEN TEN TEN TEN TEN TEN TEN TEN
+#define THO HUN HUN HUN HUN HUN HUN HUN HUN HUN HUN
+
+/* C89's minimum-maximum is 509. */
+const char x510[] = HUN HUN HUN HUN HUN TEN;
+
+/* C99's minimum-maximum is 4095. */
+const char x4096[] =
+ THO THO THO THO /* 4000 */
+ TEN TEN TEN TEN TEN /* 4050 */
+ TEN TEN TEN TEN /* 4090 */
+ "123456"; /* { dg-warning "greater than" } */
--- /dev/null
+/* -Woverlength-strings complains about string constants which are too long
+ for the C standard's "minimum maximum" limits. It is off by default,
+ but implied by -pedantic. */
+
+/* { dg-options "" } */
+
+#define TEN "xxxxxxxxxx"
+#define HUN TEN TEN TEN TEN TEN TEN TEN TEN TEN TEN
+#define THO HUN HUN HUN HUN HUN HUN HUN HUN HUN HUN
+
+/* C89's minimum-maximum is 509. */
+const char x510[] = HUN HUN HUN HUN HUN TEN;
+
+/* C99's minimum-maximum is 4095. */
+const char x4096[] =
+ THO THO THO THO /* 4000 */
+ TEN TEN TEN TEN TEN /* 4050 */
+ TEN TEN TEN TEN /* 4090 */
+ "123456";
projects / thirdparty / gcc.git / commitdiff
