]> git.ipfire.org Git - thirdparty/pdns.git/commitdiff
dnsdist: Fix a sign-comparison warning in isEDNSOptionInOpt() 6877/head
authorRemi Gacogne <remi.gacogne@powerdns.com>
Thu, 23 Aug 2018 15:23:18 +0000 (17:23 +0200)
committerRemi Gacogne <remi.gacogne@powerdns.com>
Thu, 23 Aug 2018 15:23:18 +0000 (17:23 +0200)
pdns/dnsdist-ecs.cc

index ff40bd8662f73d6866c53e7575caf30f7bfee76c..1d35a84288cab231639fbe1afa1ad50d3e48677e 100644 (file)
@@ -437,7 +437,7 @@ bool isEDNSOptionInOpt(const std::string& packet, const size_t optStart, const s
   size_t p = optStart + 9;
   uint16_t rdLen = (0x100*packet.at(p) + packet.at(p+1));
   p += sizeof(rdLen);
-  if (11 + rdLen > optLen) {
+  if (rdLen > (optLen - 11)) {
     return false;
   }