The dbsqlfuzz fuzzer found a refutation for a recent ALWAYS() macro.

FossilOrigin-Name: ebfc18aaa6506ccac80f297a1792e726972bb39c0b5c8706faadeb8df94a45e9

diff --git a/ext/rtree/rtree.c b/ext/rtree/rtree.c
index f79759a97abf8fffb563f1c16ffe10b1ff7ad096..850755820609c78a70e36daf128eb2f4ad99258a 100644 (file)
--- a/ext/rtree/rtree.c
+++ b/ext/rtree/rtree.c
@@ -2802,9 +2802,7 @@ static int fixBoundingBox(Rtree *pRtree, RtreeNode *pNode){
     }
     box.iRowid = pNode->iNode;
     rc = nodeParentIndex(pRtree, pNode, &ii);
-    /*             When we are fixing up a bounding box, we've already
-    **  vvvvvv---  decended down through the tree so we know it is correct */
-    if( ALWAYS(rc==SQLITE_OK) ){
+    if( rc==SQLITE_OK ){
       nodeOverwriteCell(pRtree, pParent, &box, ii);
       rc = fixBoundingBox(pRtree, pParent);
     }

diff --git a/manifest b/manifest
index 8a4f34bf3c02bff4f66528664f2b4062c796d6e5..96f5e2c6e01cade351e54a6ce9d095abfc853269 100644 (file)
--- a/manifest
+++ b/manifest
@@ -1,5 +1,5 @@
-C Minor\schanges\sto\srtree.c\sso\sthat\swe\scan\sget\sfull\sbranch\scoverage\seven\swhen\nit\sis\scompiled\swithout\sgeopoly.
-D 2021-09-16T20:16:39.322
+C The\sdbsqlfuzz\sfuzzer\sfound\sa\srefutation\sfor\sa\srecent\sALWAYS()\smacro.
+D 2021-09-16T22:23:36.631
 F .fossil-settings/empty-dirs dbb81e8fc0401ac46a1491ab34a7f2c7c0452f2f06b54ebb845d024ca8283ef1
 F .fossil-settings/ignore-glob 35175cdfcf539b2318cb04a9901442804be81cd677d8b889fcc9149c21f239ea
 F LICENSE.md df5091916dbb40e6e9686186587125e1b2ff51f022cc334e886c19a0e9982724
@@ -393,7 +393,7 @@ F ext/repair/test/checkindex01.test b530f141413b587c9eb78ff734de6bb79bc3515c3350
 F ext/repair/test/test.tcl 686d76d888dffd021f64260abf29a55c57b2cedfa7fc69150b42b1d6119aac3c
 F ext/rtree/README 6315c0d73ebf0ec40dedb5aa0e942bc8b54e3761
 F ext/rtree/geopoly.c 98d45533989e908bf65b43f36ff6eaad95a9ffe6f3b6b8658fbd47d45c58b10b
-F ext/rtree/rtree.c 6355ecf9a7c2f03501b654ce4dab0051407fc89fb952eec62cd0269287bd9076
+F ext/rtree/rtree.c fb930d5bee9deb9efbfbed72be56a0d4e4950ab216284fb5ec1c9863d32a32fa
 F ext/rtree/rtree.h 4a690463901cb5e6127cf05eb8e642f127012fd5003830dbc974eca5802d9412
 F ext/rtree/rtree1.test 00792b030a4e188ff1b22e8530e8aa0452bb5dd81c2b18cb004afc7dc63e040e
 F ext/rtree/rtree2.test 9d9deddbb16fd0c30c36e6b4fdc3ee3132d765567f0f9432ee71e1303d32603d
@@ -1923,7 +1923,8 @@ F vsixtest/vsixtest.tcl 6a9a6ab600c25a91a7acc6293828957a386a8a93
 F vsixtest/vsixtest.vcxproj.data 2ed517e100c66dc455b492e1a33350c1b20fbcdc
 F vsixtest/vsixtest.vcxproj.filters 37e51ffedcdb064aad6ff33b6148725226cd608e
 F vsixtest/vsixtest_TemporaryKey.pfx e5b1b036facdb453873e7084e1cae9102ccc67a0
-P b18c6ec46079520e0db8b42586ce9370a4038d0b4f719cfb98488037883e2537
-R 2ef66f05e1dd549dbc74c3eeb808a314
+P f05ae9b5864459493154037d2c902d203c4a43007b5d61bd4beb1eed56e06d13
+Q -778e4499cdf2083d5431738099dedf0aade9271f661e09ca3278e0109bb1e720
+R 412d8988f40528aa27ca17db7091e339
 U drh
-Z a0503148f3351d6802e79a654b59f6d6
+Z c4a079140a41c7dc2bd45282be1ee73a

diff --git a/manifest.uuid b/manifest.uuid
index fd4160bac2b7c4d3da53bb60cb25ecd150bd1c5c..c5b51dccb3261142f5fb57062663436ed5f7bd77 100644 (file)
--- a/manifest.uuid
+++ b/manifest.uuid
@@ -1 +1 @@
-f05ae9b5864459493154037d2c902d203c4a43007b5d61bd4beb1eed56e06d13
\ No newline at end of file
+ebfc18aaa6506ccac80f297a1792e726972bb39c0b5c8706faadeb8df94a45e9
\ No newline at end of file