f2fs: change the unlock parameter of f2fs_put_page to bool

Change the type of the unlock parameter of f2fs_put_page to bool.
All callers should consistently pass true or false. No logical change.

Signed-off-by: Yongpeng Yang <yangyongpeng@xiaomi.com>
Reviewed-by: Chao Yu <chao@kernel.org>
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>

diff --git a/fs/f2fs/compress.c b/fs/f2fs/compress.c
index 811bfe38e5c09a9b724f4d687db920bc8715fcd6..716004ba44dc1e7f619e60782513f8f173e762a3 100644 (file)
--- a/fs/f2fs/compress.c
+++ b/fs/f2fs/compress.c
@@ -120,7 +120,7 @@ static void f2fs_unlock_rpages(struct compress_ctx *cc, int len)
 }
 
 static void f2fs_put_rpages_wbc(struct compress_ctx *cc,
-               struct writeback_control *wbc, bool redirty, int unlock)
+               struct writeback_control *wbc, bool redirty, bool unlock)
 {
        unsigned int i;
 
@@ -1202,7 +1202,7 @@ bool f2fs_compress_write_end(struct inode *inode, void *fsdata,
        if (copied)
                set_cluster_dirty(&cc);
 
-       f2fs_put_rpages_wbc(&cc, NULL, false, 1);
+       f2fs_put_rpages_wbc(&cc, NULL, false, true);
        f2fs_destroy_compress_ctx(&cc, false);
 
        return first_index;
@@ -1605,7 +1605,7 @@ int f2fs_write_multi_pages(struct compress_ctx *cc,
                        add_compr_block_stat(cc->inode, cc->cluster_size);
                        goto write;
                } else if (err) {
-                       f2fs_put_rpages_wbc(cc, wbc, true, 1);
+                       f2fs_put_rpages_wbc(cc, wbc, true, true);
                        goto destroy_out;
                }
 
@@ -1619,7 +1619,7 @@ write:
        f2fs_bug_on(F2FS_I_SB(cc->inode), *submitted);
 
        err = f2fs_write_raw_pages(cc, submitted, wbc, io_type);
-       f2fs_put_rpages_wbc(cc, wbc, false, 0);
+       f2fs_put_rpages_wbc(cc, wbc, false, false);
 destroy_out:
        f2fs_destroy_compress_ctx(cc, false);
        return err;

diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c
index b92d362a02d6a0548c74a0d2e023e1301c527d51..ee519de1aa1a4266192729453568588663ddba3d 100644 (file)
--- a/fs/f2fs/data.c
+++ b/fs/f2fs/data.c
@@ -3656,8 +3656,7 @@ repeat:
        return 0;
 
 put_folio:
-       folio_unlock(folio);
-       folio_put(folio);
+       f2fs_folio_put(folio, true);
 fail:
        f2fs_write_failed(inode, pos + len);
        return err;
@@ -3713,8 +3712,7 @@ static int f2fs_write_end(const struct kiocb *iocb,
                                        pos + copied);
        }
 unlock_out:
-       folio_unlock(folio);
-       folio_put(folio);
+       f2fs_folio_put(folio, true);
        f2fs_update_time(F2FS_I_SB(inode), REQ_TIME);
        return copied;
 }

diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h
index 9ca2124aac84d064c0ef4006c9a4e01897a7f32b..d4f5648477de6a862b80ad0b6a6c49c928147b66 100644 (file)
--- a/fs/f2fs/f2fs.h
+++ b/fs/f2fs/f2fs.h
@@ -2971,7 +2971,7 @@ static inline void f2fs_folio_put(struct folio *folio, bool unlock)
        folio_put(folio);
 }
 
-static inline void f2fs_put_page(struct page *page, int unlock)
+static inline void f2fs_put_page(struct page *page, bool unlock)
 {
        if (!page)
                return;

diff --git a/fs/f2fs/gc.c b/fs/f2fs/gc.c
index 22fe6e2c6d5cda67eaa019ec405fcd9d9f4bb4db..fd8bb0424bf380fa372dc84808c77c0132fc7d43 100644 (file)
--- a/fs/f2fs/gc.c
+++ b/fs/f2fs/gc.c
@@ -1278,7 +1278,7 @@ got_it:
        err = f2fs_submit_page_bio(&fio);
        if (err)
                goto put_encrypted_page;
-       f2fs_put_page(fio.encrypted_page, 0);
+       f2fs_put_page(fio.encrypted_page, false);
        f2fs_folio_put(folio, true);
 
        f2fs_update_iostat(sbi, inode, FS_DATA_READ_IO, F2FS_BLKSIZE);
@@ -1286,7 +1286,7 @@ got_it:
 
        return 0;
 put_encrypted_page:
-       f2fs_put_page(fio.encrypted_page, 1);
+       f2fs_put_page(fio.encrypted_page, true);
 put_folio:
        f2fs_folio_put(folio, true);
        return err;
@@ -1442,7 +1442,7 @@ static int move_data_block(struct inode *inode, block_t bidx,
        f2fs_update_data_blkaddr(&dn, newaddr);
        set_inode_flag(inode, FI_APPEND_WRITE);
 
-       f2fs_put_page(fio.encrypted_page, 1);
+       f2fs_put_page(fio.encrypted_page, true);
 recover_block:
        if (err)
                f2fs_do_replace_block(fio.sbi, &sum, newaddr, fio.old_blkaddr,

diff --git a/fs/f2fs/inline.c b/fs/f2fs/inline.c
index 58ac831ef704eaadc9723f5c655f210acc78e992..e5c6a08b7e4f3fb995212750722e106cd227c768 100644 (file)
--- a/fs/f2fs/inline.c
+++ b/fs/f2fs/inline.c
@@ -287,7 +287,7 @@ int f2fs_write_inline_data(struct inode *inode, struct folio *folio)
        set_inode_flag(inode, FI_DATA_EXIST);
 
        folio_clear_f2fs_inline(ifolio);
-       f2fs_folio_put(ifolio, 1);
+       f2fs_folio_put(ifolio, true);
        return 0;
 }
 
@@ -577,7 +577,7 @@ recover:
        f2fs_i_depth_write(dir, 0);
        f2fs_i_size_write(dir, MAX_INLINE_DATA(dir));
        folio_mark_dirty(ifolio);
-       f2fs_folio_put(ifolio, 1);
+       f2fs_folio_put(ifolio, true);
 
        kfree(backup_dentry);
        return err;

diff --git a/fs/f2fs/namei.c b/fs/f2fs/namei.c
index 712479b7b93d784e62fcd14b4505d8889c8d52df..85e2d13841dab0baaf79170c28d4835bac288fdb 100644 (file)
--- a/fs/f2fs/namei.c
+++ b/fs/f2fs/namei.c
@@ -1249,11 +1249,11 @@ static int f2fs_cross_rename(struct inode *old_dir, struct dentry *old_dentry,
        return 0;
 out_new_dir:
        if (new_dir_entry) {
-               f2fs_folio_put(new_dir_folio, 0);
+               f2fs_folio_put(new_dir_folio, false);
        }
 out_old_dir:
        if (old_dir_entry) {
-               f2fs_folio_put(old_dir_folio, 0);
+               f2fs_folio_put(old_dir_folio, false);
        }
 out_new:
        f2fs_folio_put(new_folio, false);