]> git.ipfire.org Git - thirdparty/git.git/commitdiff
t-reftable-record: add index tests for reftable_record_is_deletion()
authorChandra Pratap <chandrapratap3519@gmail.com>
Tue, 2 Jul 2024 07:22:22 +0000 (12:52 +0530)
committerJunio C Hamano <gitster@pobox.com>
Tue, 2 Jul 2024 15:12:25 +0000 (08:12 -0700)
reftable_record_is_deletion() is a function defined in
reftable/record.{c, h} that determines whether a record is of
type deletion or not. In the current testing setup, this function
is left untested for index records.

Add tests for this function in the case of index records.
Note that since index records cannot be of type deletion, this function
must always return '0' when called on an index record.

Mentored-by: Patrick Steinhardt <ps@pks.im>
Mentored-by: Christian Couder <chriscool@tuxfamily.org>
Signed-off-by: Chandra Pratap <chandrapratap3519@gmail.com>
Acked-by: Karthik Nayak <karthik.188@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
t/unit-tests/t-reftable-record.c

index 1b52085f4680bd45a8825f6438173c295e9239fa..43b5d408998ea0058b4d93682cea4ab0a67b4f20 100644 (file)
@@ -466,6 +466,7 @@ static void t_reftable_index_record_roundtrip(void)
        reftable_record_key(&in, &key);
        t_copy(&in);
 
+       check(!reftable_record_is_deletion(&in));
        check(!strbuf_cmp(&key, &in.u.idx.last_key));
        n = reftable_record_encode(&in, dest, GIT_SHA1_RAWSZ);
        check_int(n, >, 0);