]> git.ipfire.org Git - thirdparty/squid.git/commitdiff
Remove useless checks and debug. size_t is guaranteed to be signed
authorAmos Jeffries <squid3@treenet.co.nz>
Wed, 16 Mar 2011 12:03:03 +0000 (01:03 +1300)
committerAmos Jeffries <squid3@treenet.co.nz>
Wed, 16 Mar 2011 12:03:03 +0000 (01:03 +1300)
Detected by ICC.

src/helper.cc

index 6c313cbd1e967792ee4e944acfb9b5c1031cd622..c7f62b2879f4d38667af57f951dd4522a423e3cc 100644 (file)
@@ -862,12 +862,8 @@ helperHandleRead(int fd, char *buf, size_t len, comm_err_t flag, int xerrno, voi
 
     debugs(84, 5, "helperHandleRead: " << len << " bytes from " << hlp->id_name << " #" << srv->index + 1);
 
-    if (flag != COMM_OK || len <= 0) {
-        if (len < 0)
-            debugs(84, 1, "helperHandleRead: FD " << fd << " read: " << xstrerror());
-
+    if (flag != COMM_OK || len == 0) {
         comm_close(fd);
-
         return;
     }
 
@@ -936,12 +932,8 @@ helperStatefulHandleRead(int fd, char *buf, size_t len, comm_err_t flag, int xer
            hlp->id_name << " #" << srv->index + 1);
 
 
-    if (flag != COMM_OK || len <= 0) {
-        if (len < 0)
-            debugs(84, 1, "helperStatefulHandleRead: FD " << fd << " read: " << xstrerror());
-
+    if (flag != COMM_OK || len == 0) {
         comm_close(fd);
-
         return;
     }