]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
batman-adv: no need to start/stop queue on mesh-iface
authorAntonio Quartulli <antonio@mandelbit.com>
Mon, 17 Mar 2025 12:39:59 +0000 (13:39 +0100)
committerSimon Wunderlich <sw@simonwunderlich.de>
Wed, 9 Apr 2025 19:59:30 +0000 (21:59 +0200)
The batman-adv mesh-iface is flagged with IFF_NO_QUEUE,
therefore there is no reason to start/stop any queue in
ndo_open/close.

Signed-off-by: Antonio Quartulli <antonio@mandelbit.com>
Signed-off-by: Simon Wunderlich <sw@simonwunderlich.de>
net/batman-adv/mesh-interface.c

index 59e7b5aacbc93554be32062eb1096f3424641188..e48b683a033ff0144a060705f5033bff1f264d8f 100644 (file)
@@ -77,18 +77,6 @@ int batadv_skb_head_push(struct sk_buff *skb, unsigned int len)
        return 0;
 }
 
-static int batadv_interface_open(struct net_device *dev)
-{
-       netif_start_queue(dev);
-       return 0;
-}
-
-static int batadv_interface_release(struct net_device *dev)
-{
-       netif_stop_queue(dev);
-       return 0;
-}
-
 /**
  * batadv_sum_counter() - Sum the cpu-local counters for index 'idx'
  * @bat_priv: the bat priv with all the mesh interface information
@@ -890,8 +878,6 @@ out:
 
 static const struct net_device_ops batadv_netdev_ops = {
        .ndo_init = batadv_meshif_init_late,
-       .ndo_open = batadv_interface_open,
-       .ndo_stop = batadv_interface_release,
        .ndo_get_stats = batadv_interface_stats,
        .ndo_vlan_rx_add_vid = batadv_interface_add_vid,
        .ndo_vlan_rx_kill_vid = batadv_interface_kill_vid,