]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
cpupower: remove stringop-truncation waring
authorAnders Roxell <anders.roxell@linaro.org>
Tue, 28 Aug 2018 09:31:18 +0000 (11:31 +0200)
committerShuah Khan (Samsung OSG) <shuah@kernel.org>
Tue, 28 Aug 2018 21:46:12 +0000 (15:46 -0600)
The strncpy doesn't null terminate the string because the size is too
short by one byte.

parse.c: In function ‘prepare_default_config’:
parse.c:148:2: warning: ‘strncpy’ output truncated before terminating
    nul copying 8 bytes from a string of the same length
    [-Wstringop-truncation]
  strncpy(config->governor, "ondemand", 8);
  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

The normal method of passing the length of the destination buffer works
correctly here.

Fixes: 7fe2f6399a84 ("cpupowerutils - cpufrequtils extended with quite some features")
Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
Signed-off-by: Shuah Khan (Samsung OSG) <shuah@kernel.org>
tools/power/cpupower/bench/parse.c

index 9ba8a44ad2a714e11cc4947e0293430ed988ba73..84caee38418f03cd2d737a113d5c37c7f19331ad 100644 (file)
@@ -145,7 +145,7 @@ struct config *prepare_default_config()
        config->cpu = 0;
        config->prio = SCHED_HIGH;
        config->verbose = 0;
-       strncpy(config->governor, "ondemand", 8);
+       strncpy(config->governor, "ondemand", sizeof(config->governor));
 
        config->output = stdout;