]> git.ipfire.org Git - thirdparty/gcc.git/commitdiff
re PR c++/49223 (Internal compiler error when using OpenMP)
authorJakub Jelinek <jakub@redhat.com>
Mon, 30 May 2011 12:16:04 +0000 (14:16 +0200)
committerJakub Jelinek <jakub@gcc.gnu.org>
Mon, 30 May 2011 12:16:04 +0000 (14:16 +0200)
PR c++/49223
* semantics.c (finish_omp_clauses): Call require_complete_type
even for copyin/copyprivate clauses.  Only call
cxx_omp_create_clause_info if inner_type is COMPLETE_TYPE_P.

* g++.dg/gomp/pr49223-1.C: New test.
* g++.dg/gomp/pr49223-2.C: New test.

From-SVN: r174432

gcc/cp/ChangeLog
gcc/cp/semantics.c
gcc/testsuite/ChangeLog
gcc/testsuite/g++.dg/gomp/pr49223-1.C [new file with mode: 0644]
gcc/testsuite/g++.dg/gomp/pr49223-2.C [new file with mode: 0644]

index 04ae40772bcdf13268e0381fa750adec8bd3b664..24aab154f86e350ccffda2dd36b2723b3b9bd24a 100644 (file)
@@ -1,3 +1,10 @@
+2011-05-30  Jakub Jelinek  <jakub@redhat.com>
+
+       PR c++/49223
+       * semantics.c (finish_omp_clauses): Call require_complete_type
+       even for copyin/copyprivate clauses.  Only call
+       cxx_omp_create_clause_info if inner_type is COMPLETE_TYPE_P.
+
 2011-05-28  Jason Merrill  <jason@redhat.com>
 
        PR c++/46124
index 854bac7d6e95e343a4a012b5c01157d9e181c795..ca9cf4bd130b2af714a6aa4c547491201ab61786 100644 (file)
@@ -4042,12 +4042,13 @@ finish_omp_clauses (tree clauses)
          break;
        }
 
-      if (need_complete_non_reference)
+      if (need_complete_non_reference || need_copy_assignment)
        {
          t = require_complete_type (t);
          if (t == error_mark_node)
            remove = true;
-         else if (TREE_CODE (TREE_TYPE (t)) == REFERENCE_TYPE)
+         else if (TREE_CODE (TREE_TYPE (t)) == REFERENCE_TYPE
+                  && need_complete_non_reference)
            {
              error ("%qE has reference type for %qs", t, name);
              remove = true;
@@ -4089,6 +4090,7 @@ finish_omp_clauses (tree clauses)
         Save the results, because later we won't be in the right context
         for making these queries.  */
       if (CLASS_TYPE_P (inner_type)
+         && COMPLETE_TYPE_P (inner_type)
          && (need_default_ctor || need_copy_ctor || need_copy_assignment)
          && !type_dependent_expression_p (t)
          && cxx_omp_create_clause_info (c, inner_type, need_default_ctor,
index 2a504c75e9e9608cbb7665a0bb9221e545f8f23f..cca41493dabcac345905bce20686cad207169892 100644 (file)
@@ -1,3 +1,9 @@
+2011-05-30  Jakub Jelinek  <jakub@redhat.com>
+
+       PR c++/49223
+       * g++.dg/gomp/pr49223-1.C: New test.
+       * g++.dg/gomp/pr49223-2.C: New test.
+
 2011-05-30  Richard Guenther  <rguenther@suse.de>
 
        PR tree-optimization/49218
diff --git a/gcc/testsuite/g++.dg/gomp/pr49223-1.C b/gcc/testsuite/g++.dg/gomp/pr49223-1.C
new file mode 100644 (file)
index 0000000..307210f
--- /dev/null
@@ -0,0 +1,28 @@
+// PR c++/49223
+// { dg-do compile }
+// { dg-options "-fopenmp" }
+
+template <int N>
+struct V
+{
+  V () {}
+  ~V () {}
+};
+
+template <int N>
+struct S
+{
+  void foo ()
+  {
+    V <0> v;
+    #pragma omp parallel private (v)
+      ;
+  }
+};
+
+void
+bar (void)
+{
+  S <0> s;
+  s.foo ();
+}
diff --git a/gcc/testsuite/g++.dg/gomp/pr49223-2.C b/gcc/testsuite/g++.dg/gomp/pr49223-2.C
new file mode 100644 (file)
index 0000000..9539773
--- /dev/null
@@ -0,0 +1,16 @@
+// PR c++/49223
+// { dg-do compile }
+// { dg-require-effective-target tls }
+// { dg-options "-fopenmp" }
+
+struct S;                      // { dg-error "forward declaration" }
+extern __thread struct S s;    // { dg-error "has incomplete type" }
+struct T;
+extern __thread struct T t;
+
+void
+foo ()
+{
+  #pragma omp parallel copyin (s)
+    ;
+}