]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
net: lan743x: Allocate rings outside ZONE_DMA
authorThangaraj Samynathan <thangaraj.s@microchip.com>
Tue, 15 Apr 2025 04:45:09 +0000 (10:15 +0530)
committerJakub Kicinski <kuba@kernel.org>
Thu, 17 Apr 2025 01:15:28 +0000 (18:15 -0700)
The driver allocates ring elements using GFP_DMA flags. There is
no dependency from LAN743x hardware on memory allocation should be
in DMA_ZONE. Hence modifying the flags to use only GFP_ATOMIC. This
is consistent with other callers of lan743x_rx_init_ring_element().

Reported-by: Zhang, Liyin(CN) <Liyin.Zhang.CN@windriver.com>
Signed-off-by: Thangaraj Samynathan <thangaraj.s@microchip.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Link: https://patch.msgid.link/20250415044509.6695-1-thangaraj.s@microchip.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/microchip/lan743x_main.c

index 23760b613d3ecfa5ac59d539e99b0c707ead40a2..8b6b9b6efe18e2a2ee1a1be3d81445726a26d888 100644 (file)
@@ -2495,8 +2495,7 @@ static int lan743x_rx_process_buffer(struct lan743x_rx *rx)
 
        /* save existing skb, allocate new skb and map to dma */
        skb = buffer_info->skb;
-       if (lan743x_rx_init_ring_element(rx, rx->last_head,
-                                        GFP_ATOMIC | GFP_DMA)) {
+       if (lan743x_rx_init_ring_element(rx, rx->last_head, GFP_ATOMIC)) {
                /* failed to allocate next skb.
                 * Memory is very low.
                 * Drop this packet and reuse buffer.