]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
i2c: thunderx: Use non-hybrid PCI devres API
authorPhilipp Stanner <phasta@kernel.org>
Thu, 17 Apr 2025 08:25:12 +0000 (10:25 +0200)
committerAndi Shyti <andi@smida.it>
Mon, 19 May 2025 20:23:57 +0000 (22:23 +0200)
thunderx enables its PCI device with pcim_enable_device(). This,
implicitly, switches the function pci_request_regions() into managed
mode, where it becomes a devres function.

The PCI subsystem wants to remove this hybrid nature from its
interfaces. To do so, users of the aforementioned combination of
functions must be ported to non-hybrid functions.

Replace the call to sometimes-managed pci_request_regions() with one to
the always-managed pcim_request_all_regions().

Signed-off-by: Philipp Stanner <phasta@kernel.org>
Link: https://lore.kernel.org/r/20250417082511.22272-3-phasta@kernel.org
Signed-off-by: Andi Shyti <andi.shyti@kernel.org>
drivers/i2c/busses/i2c-thunderx-pcidrv.c

index 0dc08cd97e8a324c5f6c09b0ced071562eaa93f3..3959f23fc4407d711418000f0c2a67ed163972a0 100644 (file)
@@ -178,7 +178,7 @@ static int thunder_i2c_probe_pci(struct pci_dev *pdev,
        if (ret)
                return ret;
 
-       ret = pci_request_regions(pdev, DRV_NAME);
+       ret = pcim_request_all_regions(pdev, DRV_NAME);
        if (ret)
                return ret;