]> git.ipfire.org Git - thirdparty/dovecot/core.git/commitdiff
login-proxy: login_proxy_new() - Change host check to assert
authorTimo Sirainen <timo.sirainen@open-xchange.com>
Thu, 9 Apr 2020 21:07:04 +0000 (00:07 +0300)
committertimo.sirainen <timo.sirainen@open-xchange.com>
Fri, 24 Apr 2020 08:02:40 +0000 (08:02 +0000)
It's already checked by the only caller.

src/login-common/login-proxy.c

index 5b255e9da1f3d6ff3ee59dbc032998d7863e32d6..5a93cceb8f0bd2e1c212488a49572127da7567b9 100644 (file)
@@ -324,14 +324,9 @@ int login_proxy_new(struct client *client, struct event *event,
 {
        struct login_proxy *proxy;
 
+       i_assert(set->host != NULL && set->host[0] != '\0');
        i_assert(client->login_proxy == NULL);
 
-       if (set->host == NULL || *set->host == '\0') {
-               e_error(event, "host not given");
-               event_unref(&event);
-               return -1;
-       }
-
        if (client->proxy_ttl <= 1) {
                e_error(event, "TTL reached zero - proxies appear to be looping?");
                event_unref(&event);