]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
qemu: qemuDomainRenameCallback: fix sending false undefined event
authorNikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
Tue, 3 Nov 2020 07:28:57 +0000 (10:28 +0300)
committerNikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
Fri, 13 Nov 2020 11:49:49 +0000 (14:49 +0300)
For example if saving config file with new name fails we send false undefine
event currently.

Signed-off-by: Nikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com>
src/qemu/qemu_driver.c

index 05f8eb2cb7614c20979ff092f795be731e2adb30..9b61e952c1abe7558ef9ccea6ded068a6d311242 100644 (file)
@@ -19147,10 +19147,6 @@ qemuDomainRenameCallback(virDomainObjPtr vm,
         }
     }
 
-    event_old = virDomainEventLifecycleNewFromObj(vm,
-                                            VIR_DOMAIN_EVENT_UNDEFINED,
-                                            VIR_DOMAIN_EVENT_UNDEFINED_RENAMED);
-
     /* Switch name in domain definition. */
     old_dom_name = vm->def->name;
     vm->def->name = new_dom_name;
@@ -19177,6 +19173,9 @@ qemuDomainRenameCallback(virDomainObjPtr vm,
         }
     }
 
+    event_old = virDomainEventLifecycleNew(vm->def->id, old_dom_name, vm->def->uuid,
+                                           VIR_DOMAIN_EVENT_UNDEFINED,
+                                           VIR_DOMAIN_EVENT_UNDEFINED_RENAMED);
     event_new = virDomainEventLifecycleNewFromObj(vm,
                                               VIR_DOMAIN_EVENT_DEFINED,
                                               VIR_DOMAIN_EVENT_DEFINED_RENAMED);