]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
drm: Consistently use struct drm_mode_rect for FB_DAMAGE_CLIPS
authorThomas Zimmermann <tzimmermann@suse.de>
Mon, 23 Sep 2024 07:58:14 +0000 (09:58 +0200)
committerThomas Zimmermann <tzimmermann@suse.de>
Wed, 25 Sep 2024 10:35:05 +0000 (12:35 +0200)
FB_DAMAGE_CLIPS is a plane property for damage handling. Its UAPI
should only use UAPI types. Hence replace struct drm_rect with
struct drm_mode_rect in drm_atomic_plane_set_property(). Both types
are identical in practice, so there's no change in behavior.

Reported-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Closes: https://lore.kernel.org/dri-devel/Zu1Ke1TuThbtz15E@intel.com/
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Fixes: d3b21767821e ("drm: Add a new plane property to send damage during plane update")
Cc: Lukasz Spintzyk <lukasz.spintzyk@displaylink.com>
Cc: Deepak Rawat <drawat@vmware.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Thomas Hellstrom <thellstrom@vmware.com>
Cc: David Airlie <airlied@gmail.com>
Cc: Simona Vetter <simona@ffwll.ch>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: Maxime Ripard <mripard@kernel.org>
Cc: Thomas Zimmermann <tzimmermann@suse.de>
Cc: dri-devel@lists.freedesktop.org
Cc: <stable@vger.kernel.org> # v5.0+
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20240923075841.16231-1-tzimmermann@suse.de
drivers/gpu/drm/drm_atomic_uapi.c

index 7936c20239551817bc8236ef6c1f65606084a39d..370dc676e3aa543c9827b50df20df78f02b738c9 100644 (file)
@@ -543,7 +543,7 @@ static int drm_atomic_plane_set_property(struct drm_plane *plane,
                                        &state->fb_damage_clips,
                                        val,
                                        -1,
-                                       sizeof(struct drm_rect),
+                                       sizeof(struct drm_mode_rect),
                                        &replaced);
                return ret;
        } else if (property == plane->scaling_filter_property) {