]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
gpio: xgene-sb: Remove unneeded definitions for properties
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Fri, 18 Oct 2024 13:45:00 +0000 (16:45 +0300)
committerBartosz Golaszewski <bartosz.golaszewski@linaro.org>
Tue, 22 Oct 2024 07:21:12 +0000 (09:21 +0200)
There are three definitions for the property names. Remove them as:
1) each of them is only used once;
2) in all cases the definition is longer than the value.

In the result code is better and grepping on the property immediately
gets the function in which is being used which helps to guess the type
of the value.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/20241018134550.2071101-2-andriy.shevchenko@linux.intel.com
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
drivers/gpio/gpio-xgene-sb.c

index 836fcf1c82fec50013d35ce8bfcb6f0a3266e85d..ae592528001d681223aa580f95ac492740dd41cb 100644 (file)
 
 #include "gpiolib-acpi.h"
 
-/* Common property names */
-#define XGENE_NIRQ_PROPERTY            "apm,nr-irqs"
-#define XGENE_NGPIO_PROPERTY           "apm,nr-gpios"
-#define XGENE_IRQ_START_PROPERTY       "apm,irq-start"
-
 #define XGENE_DFLT_MAX_NGPIO           22
 #define XGENE_DFLT_MAX_NIRQ            6
 #define XGENE_DFLT_IRQ_START_PIN       8
@@ -252,18 +247,17 @@ static int xgene_gpio_sb_probe(struct platform_device *pdev)
 
        /* Retrieve start irq pin, use default if property not found */
        priv->irq_start = XGENE_DFLT_IRQ_START_PIN;
-       if (!device_property_read_u32(&pdev->dev,
-                                       XGENE_IRQ_START_PROPERTY, &val32))
+       if (!device_property_read_u32(&pdev->dev, "apm,irq-start", &val32))
                priv->irq_start = val32;
 
        /* Retrieve number irqs, use default if property not found */
        priv->nirq = XGENE_DFLT_MAX_NIRQ;
-       if (!device_property_read_u32(&pdev->dev, XGENE_NIRQ_PROPERTY, &val32))
+       if (!device_property_read_u32(&pdev->dev, "apm,nr-irqs", &val32))
                priv->nirq = val32;
 
        /* Retrieve number gpio, use default if property not found */
        priv->gc.ngpio = XGENE_DFLT_MAX_NGPIO;
-       if (!device_property_read_u32(&pdev->dev, XGENE_NGPIO_PROPERTY, &val32))
+       if (!device_property_read_u32(&pdev->dev, "apm,nr-gpios", &val32))
                priv->gc.ngpio = val32;
 
        dev_info(&pdev->dev, "Support %d gpios, %d irqs start from pin %d\n",