Fix client-pending-auth help message in management interface

- Add the missing timeout value that is required (not optional)
- Split the long line
- Also make the AUTH_PENDING state message format in
  management-notes.txt more precise.

Signed-off-by: Selva Nair <selva.nair@gmail.com>
Acked-by:
Message-Id: <20210814044834.2236-1-selva.nair@gmail.com>
URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg22739.html
Signed-off-by: Gert Doering <gert@greenie.muc.de>

diff --git a/doc/management-notes.txt b/doc/management-notes.txt
index c20344298648cf9f1bf37204f375736e142d02a3..5b920fa508c3cc7dd8d0fdf96e9744220e671a18 100644 (file)
--- a/doc/management-notes.txt
+++ b/doc/management-notes.txt
@@ -658,7 +658,7 @@ implementations the name IV_SSO is kept in lieu of a better name.
 The management interface of the client receives notification of
 pending auth via
 
->STATE:datetime,AUTH_PENDING,[timeout number]
+>STATE:datetime,AUTH_PENDING,[timeout number],,,,,
 
 If {EXTRA} is present the client is informed using INFOMSG
 notification as

diff --git a/src/openvpn/manage.c b/src/openvpn/manage.c
index 86584c4b80233399e12b34492b025ef729c16a26..f86c87f27cd334dbbc9e76937959ec209a96dd29 100644 (file)
--- a/src/openvpn/manage.c
+++ b/src/openvpn/manage.c
@@ -104,8 +104,8 @@ man_help(void)
     msg(M_CLIENT, "client-auth-nt CID KID : Authenticate client-id/key-id CID/KID");
     msg(M_CLIENT, "client-deny CID KID R [CR] : Deny auth client-id/key-id CID/KID with log reason");
     msg(M_CLIENT, "                             text R and optional client reason text CR");
-    msg(M_CLIENT, "client-pending-auth CID MSG : Instruct OpenVPN to send AUTH_PENDING and INFO_PRE msg"
-        "                          to the client and wait for a final client-auth/client-deny");
+    msg(M_CLIENT, "client-pending-auth CID MSG timeout : Instruct OpenVPN to send AUTH_PENDING and INFO_PRE msg");
+    msg(M_CLIENT, "                                      to the client and wait for a final client-auth/client-deny");
     msg(M_CLIENT, "client-kill CID [M]    : Kill client instance CID with message M (def=RESTART)");
     msg(M_CLIENT, "env-filter [level]     : Set env-var filter level");
 #ifdef MANAGEMENT_PF