]> git.ipfire.org Git - thirdparty/xfsprogs-dev.git/commitdiff
mkfs: Fix memory leak
authorPavel Reichl <preichl@redhat.com>
Fri, 27 May 2022 20:36:21 +0000 (16:36 -0400)
committerEric Sandeen <sandeen@sandeen.net>
Fri, 27 May 2022 20:36:21 +0000 (16:36 -0400)
'value' is allocated by strdup() in getstr(). It
needs to be freed as we do not keep any permanent
reference to it.

Signed-off-by: Pavel Reichl <preichl@redhat.com>
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
mkfs/xfs_mkfs.c

index 01d2e8cadc4033cf313192b6e05d9c1ad9583532..a37d6848a23b3b6e84bac81e0eb2922952404556 100644 (file)
@@ -1714,6 +1714,7 @@ naming_opts_parser(
                } else {
                        cli->sb_feat.dir_version = getnum(value, opts, subopt);
                }
+               free((char *)value);
                break;
        case N_FTYPE:
                cli->sb_feat.dirftype = getnum(value, opts, subopt);