]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
drm/i915: Fix HAS_REGION() usage in intel_gt_probe_lmem()
authorVille Syrjälä <ville.syrjala@linux.intel.com>
Thu, 2 May 2024 12:14:21 +0000 (15:14 +0300)
committerVille Syrjälä <ville.syrjala@linux.intel.com>
Wed, 8 May 2024 11:22:34 +0000 (14:22 +0300)
HAS_REGION() takes a bitmask, not the region ID. This causes the
GEM_BUG_ON() to assert that the SMEM region is available rather
than the intended LMEM region. No real harm since SMEM is always
available, but also not checking what was intended.

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20240502121423.1002-1-ville.syrjala@linux.intel.com
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
drivers/gpu/drm/i915/gt/intel_gt.c

index 45920cda0cc779e2d96093d1ad9b9769c79df500..96b444905d8cedbaf04306a952f34823ba349fd4 100644 (file)
@@ -105,7 +105,7 @@ static int intel_gt_probe_lmem(struct intel_gt *gt)
 
        intel_memory_region_set_name(mem, "local%u", mem->instance);
 
-       GEM_BUG_ON(!HAS_REGION(i915, id));
+       GEM_BUG_ON(!HAS_REGION(i915, BIT(id)));
        GEM_BUG_ON(i915->mm.regions[id]);
        i915->mm.regions[id] = mem;