]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
drm/amd/display: Skip to enable dsc if it has been off
authorPaul Hsieh <Paul.Hsieh@amd.com>
Tue, 11 Mar 2025 09:16:57 +0000 (17:16 +0800)
committerAlex Deucher <alexander.deucher@amd.com>
Mon, 7 Apr 2025 19:18:30 +0000 (15:18 -0400)
[Why]
It makes DSC enable when we commit the stream which need
keep power off.And then it will skip to disable DSC if
pipe reset at this situation as power has been off. It may
cause the DSC unexpected enable on the pipe with the
next new stream which doesn't support DSC.

[HOW]
Check the DSC used on current pipe status when update stream.
Skip to enable if it has been off. The operation enable
DSC should happen when set power on.

Reviewed-by: Wenjing Liu <wenjing.liu@amd.com>
Signed-off-by: Paul Hsieh <Paul.Hsieh@amd.com>
Signed-off-by: Aurabindo Pillai <aurabindo.pillai@amd.com>
Tested-by: Daniel Wheeler <daniel.wheeler@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/display/dc/hwss/dcn314/dcn314_hwseq.c

index be26c925fdfa1a969b04a4cc9bbca2e09f0e158c..e68f21fd5f0fb498699d8ecd688fb552e1577a86 100644 (file)
@@ -84,6 +84,20 @@ static void update_dsc_on_stream(struct pipe_ctx *pipe_ctx, bool enable)
                struct dsc_config dsc_cfg;
                struct dsc_optc_config dsc_optc_cfg = {0};
                enum optc_dsc_mode optc_dsc_mode;
+               struct dcn_dsc_state dsc_state = {0};
+
+               if (!dsc) {
+                       DC_LOG_DSC("DSC is NULL for tg instance %d:", pipe_ctx->stream_res.tg->inst);
+                       return;
+               }
+
+               if (dsc->funcs->dsc_read_state) {
+                       dsc->funcs->dsc_read_state(dsc, &dsc_state);
+                       if (!dsc_state.dsc_fw_en) {
+                               DC_LOG_DSC("DSC has been disabled for tg instance %d:", pipe_ctx->stream_res.tg->inst);
+                               return;
+                       }
+               }
 
                /* Enable DSC hw block */
                dsc_cfg.pic_width = (stream->timing.h_addressable + stream->timing.h_border_left + stream->timing.h_border_right) / opp_cnt;