]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
kconfig: gconf: fix potential memory leak in renderer_edited()
authorMasahiro Yamada <masahiroy@kernel.org>
Tue, 24 Jun 2025 15:04:55 +0000 (00:04 +0900)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 20 Aug 2025 16:41:31 +0000 (18:41 +0200)
[ Upstream commit f72ed4c6a375e52a3f4b75615e4a89d29d8acea7 ]

If gtk_tree_model_get_iter() fails, gtk_tree_path_free() is not called.

Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Acked-by: Randy Dunlap <rdunlap@infradead.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
scripts/kconfig/gconf.c

index abe4cfe66b146f47e8dd50b68ffc50418b12a2b0..0caf0ced13df4a5cbf047bf25e9a3be399e4c1ee 100644 (file)
@@ -748,7 +748,7 @@ static void renderer_edited(GtkCellRendererText * cell,
        struct symbol *sym;
 
        if (!gtk_tree_model_get_iter(model2, &iter, path))
-               return;
+               goto free;
 
        gtk_tree_model_get(model2, &iter, COL_MENU, &menu, -1);
        sym = menu->sym;
@@ -760,6 +760,7 @@ static void renderer_edited(GtkCellRendererText * cell,
 
        update_tree(&rootmenu, NULL);
 
+free:
        gtk_tree_path_free(path);
 }