]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
xfs: remove the redundant xfs_alloc_log_agf
authorLong Li <leo.lilong@huawei.com>
Mon, 30 Sep 2024 10:42:17 +0000 (18:42 +0800)
committerCarlos Maiolino <cem@kernel.org>
Tue, 5 Nov 2024 12:51:55 +0000 (13:51 +0100)
There are two invocations of xfs_alloc_log_agf in xfs_alloc_put_freelist.
The AGF does not change between the two calls. Although this does not pose
any practical problems, it seems like a small mistake. Therefore, fix it
by removing the first xfs_alloc_log_agf invocation.

Signed-off-by: Long Li <leo.lilong@huawei.com>
Reviewed-by: Dave Chinner <dchinner@redhat.com>
Signed-off-by: Carlos Maiolino <cem@kernel.org>
fs/xfs/libxfs/xfs_alloc.c

index 22bdbb3e9980c414c4a6e17f47b06f9965ecf45c..68643a3592ac05b0f47333ed21b3c05743edb796 100644 (file)
@@ -3156,8 +3156,6 @@ xfs_alloc_put_freelist(
                logflags |= XFS_AGF_BTREEBLKS;
        }
 
-       xfs_alloc_log_agf(tp, agbp, logflags);
-
        ASSERT(be32_to_cpu(agf->agf_flcount) <= xfs_agfl_size(mp));
 
        agfl_bno = xfs_buf_to_agfl_bno(agflbp);