]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
qemu_driver: Resolve Coverity CONSTANT_EXPRESSION_RESULT
authorJohn Ferlan <jferlan@redhat.com>
Wed, 27 Aug 2014 13:14:16 +0000 (09:14 -0400)
committerEric Blake <eblake@redhat.com>
Wed, 16 Dec 2015 03:51:05 +0000 (20:51 -0700)
The call to virDomainSnapshotRedefinePrep() had a spurrious ! in front of
it which caused Coverity to complan that the expression is always false.

(cherry picked from commit 9d7254de430f7ef7a4c6a2a20718942369ce9d06)

src/qemu/qemu_driver.c

index 8e65eeb497a79c6e667f4f1260dd1469e0a4b708..b3f47d12ce39140a236bc4112dab30008b5c2ce5 100644 (file)
@@ -13357,8 +13357,8 @@ qemuDomainSnapshotCreateXML(virDomainPtr domain,
     }
 
     if (redefine) {
-        if (!virDomainSnapshotRedefinePrep(domain, vm, &def, &snap,
-                                           &update_current, flags) < 0)
+        if (virDomainSnapshotRedefinePrep(domain, vm, &def, &snap,
+                                          &update_current, flags) < 0)
             goto cleanup;
     } else {
         /* Easiest way to clone inactive portion of vm->def is via