]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
scsi: qedf: Simplify alloc_workqueue() invocations
authorBart Van Assche <bvanassche@acm.org>
Thu, 22 Aug 2024 19:59:16 +0000 (12:59 -0700)
committerMartin K. Petersen <martin.petersen@oracle.com>
Fri, 23 Aug 2024 01:28:56 +0000 (21:28 -0400)
Let alloc_workqueue() format the workqueue name instead of calling
snprintf() explicitly.

Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Link: https://lore.kernel.org/r/20240822195944.654691-13-bvanassche@acm.org
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/qedf/qedf_main.c

index 119afcaf6e13bc563cc06ca9d67f3c7ff17d436b..cf13148ba281c1efccb7e3871717d41f6e711dab 100644 (file)
@@ -3372,10 +3372,8 @@ retry_probe:
        QEDF_INFO(&(qedf->dbg_ctx), QEDF_LOG_INFO, "qedf->io_mempool=%p.\n",
            qedf->io_mempool);
 
-       sprintf(host_buf, "qedf_%u_link",
-           qedf->lport->host->host_no);
-       qedf->link_update_wq =
-               alloc_workqueue("%s", WQ_MEM_RECLAIM, 1, host_buf);
+       qedf->link_update_wq = alloc_workqueue("qedf_%u_link", WQ_MEM_RECLAIM,
+                                              1, qedf->lport->host->host_no);
        INIT_DELAYED_WORK(&qedf->link_update, qedf_handle_link_update);
        INIT_DELAYED_WORK(&qedf->link_recovery, qedf_link_recovery);
        INIT_DELAYED_WORK(&qedf->grcdump_work, qedf_wq_grcdump);
@@ -3585,8 +3583,8 @@ retry_probe:
        ether_addr_copy(params.ll2_mac_address, qedf->mac);
 
        /* Start LL2 processing thread */
-       snprintf(host_buf, 20, "qedf_%d_ll2", host->host_no);
-       qedf->ll2_recv_wq = alloc_workqueue("%s", WQ_MEM_RECLAIM, 1, host_buf);
+       qedf->ll2_recv_wq = alloc_workqueue("qedf_%d_ll2", WQ_MEM_RECLAIM, 1,
+                                           host->host_no);
        if (!qedf->ll2_recv_wq) {
                QEDF_ERR(&(qedf->dbg_ctx), "Failed to LL2 workqueue.\n");
                rc = -ENOMEM;
@@ -3627,9 +3625,8 @@ retry_probe:
                }
        }
 
-       sprintf(host_buf, "qedf_%u_timer", qedf->lport->host->host_no);
-       qedf->timer_work_queue =
-               alloc_workqueue("%s", WQ_MEM_RECLAIM, 1, host_buf);
+       qedf->timer_work_queue = alloc_workqueue("qedf_%u_timer",
+                               WQ_MEM_RECLAIM, 1, qedf->lport->host->host_no);
        if (!qedf->timer_work_queue) {
                QEDF_ERR(&(qedf->dbg_ctx), "Failed to start timer "
                          "workqueue.\n");