]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
media: i2c: imx214: Use __free(fwnode_handle)
authorAndré Apitzsch <git@apitzsch.eu>
Mon, 30 Jun 2025 19:05:23 +0000 (21:05 +0200)
committerHans Verkuil <hverkuil+cisco@kernel.org>
Mon, 25 Aug 2025 13:40:39 +0000 (15:40 +0200)
Use the __free(fwnode_handle) hook to free the endpoint when the
function exits to simplify the error path.

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: André Apitzsch <git@apitzsch.eu>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Hans Verkuil <hverkuil+cisco@kernel.org>
drivers/media/i2c/imx214.c

index 2baee25368c44c8a77d33f1b234c0a81687e0d00..4157f142b59b2208ade585efbe7fdabf1d543f74 100644 (file)
@@ -1326,8 +1326,8 @@ static int imx214_identify_module(struct imx214 *imx214)
 
 static int imx214_parse_fwnode(struct imx214 *imx214)
 {
+       struct fwnode_handle *endpoint __free(fwnode_handle) = NULL;
        struct v4l2_fwnode_endpoint *bus_cfg = &imx214->bus_cfg;
-       struct fwnode_handle *endpoint;
        struct device *dev = imx214->dev;
        unsigned int i;
        int ret;
@@ -1338,11 +1338,8 @@ static int imx214_parse_fwnode(struct imx214 *imx214)
 
        bus_cfg->bus_type = V4L2_MBUS_CSI2_DPHY;
        ret = v4l2_fwnode_endpoint_alloc_parse(endpoint, bus_cfg);
-       fwnode_handle_put(endpoint);
-       if (ret) {
-               dev_err_probe(dev, ret, "parsing endpoint node failed\n");
-               goto error;
-       }
+       if (ret)
+               return dev_err_probe(dev, ret, "parsing endpoint node failed\n");
 
        /* Check the number of MIPI CSI2 data lanes */
        if (bus_cfg->bus.mipi_csi2.num_data_lanes != 4) {