Bug #887: LDAP helpers TLS mode does not work

The TLS mode of the LDAP helpers did not work and always reported "TLS
Connection failed"

diff --git a/helpers/basic_auth/LDAP/squid_ldap_auth.c b/helpers/basic_auth/LDAP/squid_ldap_auth.c
index d091cdbc2dda4d050a2ea13ca03d3c2b1507b065..6a9dec01e88ff84aa1b98c07ad58fc9b09580c2f 100644 (file)
--- a/helpers/basic_auth/LDAP/squid_ldap_auth.c
+++ b/helpers/basic_auth/LDAP/squid_ldap_auth.c
@@ -445,7 +445,7 @@ main(int argc, char **argv)
                 exit(1);
            }
 
-           if ( use_tls && ( version == LDAP_VERSION3 ) && ( ldap_start_tls_s( ld, NULL, NULL ) == LDAP_SUCCESS )) {
+           if ( use_tls && ( version == LDAP_VERSION3 ) && ( ldap_start_tls_s( ld, NULL, NULL ) != LDAP_SUCCESS )) {
                 fprintf( stderr, "Could not Activate TLS connection\n");
                 exit(1);
            }

diff --git a/helpers/external_acl/ldap_group/squid_ldap_group.c b/helpers/external_acl/ldap_group/squid_ldap_group.c
index 07df42b3876948304b29a9128e09a8aeb61e97ea..98b9251b7ebcd217065634302b5227f8fd44a666 100644 (file)
--- a/helpers/external_acl/ldap_group/squid_ldap_group.c
+++ b/helpers/external_acl/ldap_group/squid_ldap_group.c
@@ -488,7 +488,7 @@ main(int argc, char **argv)
                    ld = NULL;
                    break;
                }
-               if (use_tls && (version == LDAP_VERSION3) && (ldap_start_tls_s(ld, NULL, NULL) == LDAP_SUCCESS)) {
+               if (use_tls && (version == LDAP_VERSION3) && (ldap_start_tls_s(ld, NULL, NULL) != LDAP_SUCCESS)) {
                    fprintf(stderr, "Could not Activate TLS connection\n");
                    ldap_unbind(ld);
                    ld = NULL;