]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
media: i2c: mt9m001: Drop check for reentrant .s_stream()
authorLaurent Pinchart <laurent.pinchart@ideasonboard.com>
Thu, 14 Sep 2023 18:16:20 +0000 (21:16 +0300)
committerHans Verkuil <hverkuil-cisco@xs4all.nl>
Wed, 27 Sep 2023 07:39:58 +0000 (09:39 +0200)
The subdev .s_stream() operation shall not be called to start streaming
on an already started subdev, or stop streaming on a stopped subdev.
Remove the check that guards against that condition.

The streaming field of the driver's private structure is now unused,
drop it as well.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
drivers/media/i2c/mt9m001.c

index ce9568e8391cddf8eef06afb14f77dd3dcd7db6d..79192cf79d28745ffc9b6335d043c8321e7664cf 100644 (file)
@@ -93,7 +93,6 @@ struct mt9m001 {
                struct v4l2_ctrl *autoexposure;
                struct v4l2_ctrl *exposure;
        };
-       bool streaming;
        struct mutex mutex;
        struct v4l2_rect rect;  /* Sensor window */
        struct clk *clk;
@@ -213,9 +212,6 @@ static int mt9m001_s_stream(struct v4l2_subdev *sd, int enable)
 
        mutex_lock(&mt9m001->mutex);
 
-       if (mt9m001->streaming == enable)
-               goto done;
-
        if (enable) {
                ret = pm_runtime_resume_and_get(&client->dev);
                if (ret < 0)
@@ -239,8 +235,6 @@ static int mt9m001_s_stream(struct v4l2_subdev *sd, int enable)
                pm_runtime_put(&client->dev);
        }
 
-       mt9m001->streaming = enable;
-done:
        mutex_unlock(&mt9m001->mutex);
 
        return 0;