tests: avoid spurious failure of 'uninstall-fail.test' on Cygwin

* tests/uninstall-fail.test: Be sure to really skip this test
on systems that allows files to be removed from unwritable
directories.  Motivated by a spurious failure on Cygwin 1.5.

diff --git a/ChangeLog b/ChangeLog
index c3b041d262c910e210b7de2711d4e54c9af7a409..44240f9c6d4814596b40e698f11b65f27e61de3f 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,10 @@
+2011-10-19  Stefano Lattarini  <stefano.lattarini@gmail.com>
+
+       tests: avoid spurious failure of 'uninstall-fail.test' on Cygwin
+       * tests/uninstall-fail.test: Be sure to really skip this test
+       on systems that allows files to be removed from unwritable
+       directories.  Motivated by a spurious failure on Cygwin 1.5.
+
 2011-09-28  Stefano Lattarini  <stefano.lattarini@gmail.com>
 
        maintcheck: fix usage of `cd' instead of `$(am__cd)'

diff --git a/tests/uninstall-fail.test b/tests/uninstall-fail.test
index a3e7a7a9a2019656963f3572f472bc11f9b742c6..a57b6652fc593dd0bd1eee6e2e9738064a1bd3e5 100755 (executable)
--- a/tests/uninstall-fail.test
+++ b/tests/uninstall-fail.test
@@ -24,6 +24,11 @@
 
 set -e
 
+mkdir d
+: > d/f
+chmod a-w d || skip "cannot make directories unwritable"
+rm -f d/f && skip_ "can delete files from unwritable directories"
+
 cat >> configure.in << 'END'
 AC_OUTPUT
 END
@@ -46,9 +51,6 @@ mkdir $inst $inst/share
 : > $inst/share/foobar.txt
 
 chmod a-w $inst/share
-touch $inst/share/t && skip_ "cannot make directories unwritable"
-rm -f $inst/share/t
-
 $MAKE uninstall >output 2>&1 && { cat output; Exit 1; }
 cat output
 grep "rm: .*foobar\.txt" output