]> git.ipfire.org Git - thirdparty/foundation/foundation-sites.git/commitdiff
Hide close-button for in-canvas and reveal-for-x via CSS
authorKai Falkowski <kai.falkowski@gmail.com>
Wed, 21 Jun 2017 22:34:39 +0000 (00:34 +0200)
committerKai Falkowski <kai.falkowski@gmail.com>
Wed, 21 Jun 2017 22:34:39 +0000 (00:34 +0200)
Since reveal-for-x uses now CSS for hiding the related JS for the inline style is removed.

js/foundation.offcanvas.js
scss/components/_off-canvas.scss

index 00f4731330ad31688d75bc6068eeb006a78fc91b..3d8aeceb901c9d2b189b29880b193955eab0e0e6 100644 (file)
@@ -199,14 +199,12 @@ class OffCanvas extends Plugin {
    * @function
    */
   reveal(isRevealed) {
-    var $closer = this.$element.find('[data-close]');
     if (isRevealed) {
       this.close();
       this.isRevealed = true;
       this.$element.attr('aria-hidden', 'false');
       this.$element.off('open.zf.trigger toggle.zf.trigger');
       this.$element.removeClass('is-closed');
-      if ($closer.length) { $closer.hide(); }
     } else {
       this.isRevealed = false;
       this.$element.attr('aria-hidden', 'true');
@@ -215,9 +213,6 @@ class OffCanvas extends Plugin {
         'toggle.zf.trigger': this.toggle.bind(this)
       });
       this.$element.addClass('is-closed');
-      if ($closer.length) {
-        $closer.show();
-      }
     }
     this._addContentClasses(isRevealed);
   }
index 0a12e4738c7bfd63d322290a96bc043edfe6d636..ba1f9f3ca19fef18bd8b175fcf5520b281016afd 100644 (file)
@@ -329,6 +329,10 @@ $content: $maincontent-class
     position: absolute;
   }
 
+  .close-button {
+    display: none;
+  }
+
   @at-root .#{$content}.has-reveal-#{$position} {
     margin-#{$position}: $offcanvas-size;
   }
@@ -357,6 +361,10 @@ $content: $maincontent-class
     box-shadow: none;
     transform: none;
   }
+
+  .close-button {
+    display: none;
+  }
 }
 
 @mixin foundation-off-canvas {