]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
spi: mt65xx: Use IRQF_ONESHOT with threaded IRQ
authorFei Shao <fshao@chromium.org>
Wed, 17 Dec 2025 10:10:47 +0000 (18:10 +0800)
committerMark Brown <broonie@kernel.org>
Wed, 17 Dec 2025 12:01:17 +0000 (12:01 +0000)
This driver is migrated to use threaded IRQ since commit 5972eb05ca32
("spi: spi-mt65xx: Use threaded interrupt for non-SPIMEM transfer"), and
we almost always want to disable the interrupt line to avoid excess
interrupts while the threaded handler is processing SPI transfer.
Use IRQF_ONESHOT for that purpose.

In practice, we see MediaTek devices show SPI transfer timeout errors
when communicating with ChromeOS EC in certain scenarios, and with
IRQF_ONESHOT, the issue goes away.

Signed-off-by: Fei Shao <fshao@chromium.org>
Link: https://patch.msgid.link/20251217101131.1975131-1-fshao@chromium.org
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-mt65xx.c

index 4b40985af1eaf0f7ff704b5ebf624def7d5ae94e..90e5813cfdc332c60382a59c1d53cc30f3861ba6 100644 (file)
@@ -1320,7 +1320,7 @@ static int mtk_spi_probe(struct platform_device *pdev)
 
        ret = devm_request_threaded_irq(dev, irq, mtk_spi_interrupt,
                                        mtk_spi_interrupt_thread,
-                                       IRQF_TRIGGER_NONE, dev_name(dev), host);
+                                       IRQF_ONESHOT, dev_name(dev), host);
        if (ret)
                return dev_err_probe(dev, ret, "failed to register irq\n");