]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
pinctrl: Simplify printks with pOF format
authorKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Fri, 12 Sep 2025 09:23:52 +0000 (11:23 +0200)
committerLinus Walleij <linus.walleij@linaro.org>
Fri, 12 Sep 2025 12:19:31 +0000 (14:19 +0200)
Print full device node name with %pOF format, so the code will be a bit
simpler.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/pinctrl/sprd/pinctrl-sprd.c
drivers/pinctrl/sunxi/pinctrl-sunxi-dt.c

index c4a1d99dfed0431015f34554673b9e2853a6dbd1..16cf9d15f2470706bd7b3d4c189f36b4bd3c5d39 100644 (file)
@@ -258,8 +258,7 @@ static int sprd_dt_node_to_map(struct pinctrl_dev *pctldev,
 
        grp = sprd_pinctrl_find_group_by_name(pctl, np->name);
        if (!grp) {
-               dev_err(pctl->dev, "unable to find group for node %s\n",
-                       of_node_full_name(np));
+               dev_err(pctl->dev, "unable to find group for node %pOF\n", np);
                return -EINVAL;
        }
 
@@ -276,16 +275,14 @@ static int sprd_dt_node_to_map(struct pinctrl_dev *pctldev,
        if (ret < 0) {
                if (ret != -EINVAL)
                        dev_err(pctl->dev,
-                               "%s: could not parse property function\n",
-                               of_node_full_name(np));
+                               "%pOF: could not parse property function\n", np);
                function = NULL;
        }
 
        ret = pinconf_generic_parse_dt_config(np, pctldev, &configs,
                                              &num_configs);
        if (ret < 0) {
-               dev_err(pctl->dev, "%s: could not parse node property\n",
-                       of_node_full_name(np));
+               dev_err(pctl->dev, "%pOF: could not parse node property\n", np);
                return ret;
        }
 
index 5f13315ebff340283ffb8bcbb8695830d9d714c9..50a16f3bd13161066ab735aa7e6642e404a282fe 100644 (file)
@@ -274,8 +274,7 @@ static void fill_pin_function(struct device *dev, struct device_node *node,
                        if (!strcmp(pins[pin].pin.name, name))
                                break;
                if (pin == npins) {
-                       dev_warn(dev, "%s: cannot find pin %s\n",
-                                of_node_full_name(node), name);
+                       dev_warn(dev, "%pOF: cannot find pin %s\n", node, name);
                        index++;
                        continue;
                }
@@ -283,8 +282,8 @@ static void fill_pin_function(struct device *dev, struct device_node *node,
                /* Read the associated mux value. */
                muxval = sunxi_pinctrl_dt_read_pinmux(node, index);
                if (muxval == INVALID_MUX) {
-                       dev_warn(dev, "%s: invalid mux value for pin %s\n",
-                                of_node_full_name(node), name);
+                       dev_warn(dev, "%pOF: invalid mux value for pin %s\n",
+                                node, name);
                        index++;
                        continue;
                }