]> git.ipfire.org Git - thirdparty/kernel/stable-queue.git/commitdiff
fixes for 5.2
authorSasha Levin <sashal@kernel.org>
Mon, 26 Aug 2019 19:26:35 +0000 (15:26 -0400)
committerSasha Levin <sashal@kernel.org>
Mon, 26 Aug 2019 19:26:35 +0000 (15:26 -0400)
Signed-off-by: Sasha Levin <sashal@kernel.org>
queue-5.2/dm-zoned-fix-potential-null-dereference-in-dmz_do_re.patch [new file with mode: 0644]
queue-5.2/series

diff --git a/queue-5.2/dm-zoned-fix-potential-null-dereference-in-dmz_do_re.patch b/queue-5.2/dm-zoned-fix-potential-null-dereference-in-dmz_do_re.patch
new file mode 100644 (file)
index 0000000..1827a6f
--- /dev/null
@@ -0,0 +1,45 @@
+From 633359def59c4915de155e151bdcc99711fa6512 Mon Sep 17 00:00:00 2001
+From: Dan Carpenter <dan.carpenter@oracle.com>
+Date: Mon, 19 Aug 2019 12:58:14 +0300
+Subject: dm zoned: fix potential NULL dereference in dmz_do_reclaim()
+
+[ Upstream commit e0702d90b79d430b0ccc276ead4f88440bb51352 ]
+
+This function is supposed to return error pointers so it matches the
+dmz_get_rnd_zone_for_reclaim() function.  The current code could lead to
+a NULL dereference in dmz_do_reclaim()
+
+Fixes: b234c6d7a703 ("dm zoned: improve error handling in reclaim")
+Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
+Reviewed-by: Dmitry Fomichev <dmitry.fomichev@wdc.com>
+Signed-off-by: Mike Snitzer <snitzer@redhat.com>
+Signed-off-by: Sasha Levin <sashal@kernel.org>
+---
+ drivers/md/dm-zoned-metadata.c | 4 ++--
+ 1 file changed, 2 insertions(+), 2 deletions(-)
+
+diff --git a/drivers/md/dm-zoned-metadata.c b/drivers/md/dm-zoned-metadata.c
+index 00e7a343eacf1..7e8d7fc99410d 100644
+--- a/drivers/md/dm-zoned-metadata.c
++++ b/drivers/md/dm-zoned-metadata.c
+@@ -1579,7 +1579,7 @@ static struct dm_zone *dmz_get_seq_zone_for_reclaim(struct dmz_metadata *zmd)
+       struct dm_zone *zone;
+       if (list_empty(&zmd->map_seq_list))
+-              return NULL;
++              return ERR_PTR(-EBUSY);
+       list_for_each_entry(zone, &zmd->map_seq_list, link) {
+               if (!zone->bzone)
+@@ -1588,7 +1588,7 @@ static struct dm_zone *dmz_get_seq_zone_for_reclaim(struct dmz_metadata *zmd)
+                       return zone;
+       }
+-      return NULL;
++      return ERR_PTR(-EBUSY);
+ }
+ /*
+-- 
+2.20.1
+
index f23dbfb074f937f8c5c363288dba1f01315b8da1..53092549e48cad09f5f6d7058e116a56b4488cb1 100644 (file)
@@ -153,3 +153,4 @@ mm-zsmalloc.c-fix-race-condition-in-zs_destroy_pool.patch
 mm-kasan-fix-false-positive-invalid-free-reports-with-config_kasan_sw_tags-y.patch
 xfs-fix-missing-ilock-unlock-when-xfs_setattr_nonsize-fails-due-to-edquot.patch
 ib-hfi1-drop-stale-tid-rdma-packets.patch
+dm-zoned-fix-potential-null-dereference-in-dmz_do_re.patch