hwmon: (adc128d818) Fix underflows seen when writing limit attributes

DIV_ROUND_CLOSEST() after kstrtol() results in an underflow if a large
negative number such as -9223372036854775808 is provided by the user.
Fix it by reordering clamp_val() and DIV_ROUND_CLOSEST() operations.

Signed-off-by: Guenter Roeck <linux@roeck-us.net>

diff --git a/drivers/hwmon/adc128d818.c b/drivers/hwmon/adc128d818.c
index 8ac6e735ec5cf7d4e15be66610be01d8cb70c3b6..5e805d4ee76ab4d7354a76884a4b4864775eb3f6 100644 (file)
--- a/drivers/hwmon/adc128d818.c
+++ b/drivers/hwmon/adc128d818.c
@@ -175,7 +175,7 @@ static ssize_t adc128_in_store(struct device *dev,
 
        mutex_lock(&data->update_lock);
        /* 10 mV LSB on limit registers */
-       regval = clamp_val(DIV_ROUND_CLOSEST(val, 10), 0, 255);
+       regval = DIV_ROUND_CLOSEST(clamp_val(val, 0, 2550), 10);
        data->in[index][nr] = regval << 4;
        reg = index == 1 ? ADC128_REG_IN_MIN(nr) : ADC128_REG_IN_MAX(nr);
        i2c_smbus_write_byte_data(data->client, reg, regval);
@@ -213,7 +213,7 @@ static ssize_t adc128_temp_store(struct device *dev,
                return err;
 
        mutex_lock(&data->update_lock);
-       regval = clamp_val(DIV_ROUND_CLOSEST(val, 1000), -128, 127);
+       regval = DIV_ROUND_CLOSEST(clamp_val(val, -128000, 127000), 1000);
        data->temp[index] = regval << 1;
        i2c_smbus_write_byte_data(data->client,
                                  index == 1 ? ADC128_REG_TEMP_MAX