Add va_end for every va_start.

  Dotan Barak, dotanba at gmail dot com

git-svn-id: http://svn.metaparadigm.com/svn/json-c/trunk@23 327403b1-1117-474d-bef2-5cb71233fd97

diff --git a/ChangeLog b/ChangeLog
index 0c964d67e9898b0b4487553bbc7b8b765a61d5f9..784663a733d1c3485fb9d7675325ddf88cb04847 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,4 +1,6 @@
 0.8
+  * Add va_end for every va_start
+    Dotan Barak, dotanba at gmail dot com
   * Add macros to enable compiling out debug code
     Geoffrey Young, geoff at modperlcookbook dot org
   * Fix bug with use of capital E in numbers with exponents

diff --git a/debug.c b/debug.c
index eaa6fca33c99bdc10437145427eff0c92b6b86a2..f6999765de12c8114126ad9ea1187e6e0d961d6d 100644 (file)
--- a/debug.c
+++ b/debug.c
@@ -51,6 +51,7 @@ void mc_abort(const char *msg, ...)
   } else
 #endif
          vprintf(msg, ap);
+  va_end(ap);
   exit(1);
 }
 
@@ -66,6 +67,7 @@ void mc_debug(const char *msg, ...)
        } else
 #endif
                vprintf(msg, ap);
+    va_end(ap);
   }
 }
 
@@ -79,6 +81,7 @@ void mc_error(const char *msg, ...)
        } else
 #endif
                vfprintf(stderr, msg, ap);
+  va_end(ap);
 }
 
 void mc_info(const char *msg, ...)
@@ -91,4 +94,5 @@ void mc_info(const char *msg, ...)
        } else 
 #endif
                vfprintf(stderr, msg, ap);
+  va_end(ap);
 }

diff --git a/linkhash.c b/linkhash.c
index 6cfc9a0ea6e4f633335184966439b57fa1a148c4..fc72bf667e90782092a849adf4f5cae9d25848b5 100644 (file)
--- a/linkhash.c
+++ b/linkhash.c
@@ -25,6 +25,7 @@ void lh_abort(const char *msg, ...)
        va_list ap;
        va_start(ap, msg);
        vprintf(msg, ap);
+       va_end(ap);
        exit(1);
 }
 

diff --git a/printbuf.c b/printbuf.c
index 0ee45e093ae0efb5055c9ad0765f78303a283085..cdda47eda942222436a4708f01d9886fb8a50f9a 100644 (file)
--- a/printbuf.c
+++ b/printbuf.c
@@ -119,8 +119,9 @@ int sprintbuf(struct printbuf *p, const char *msg, ...)
   if(size == -1 || size > 127) {
     int ret;
     va_start(ap, msg);
-    if((size = vasprintf(&t, msg, ap)) == -1) return -1;
+    size = vasprintf(&t, msg, ap);
     va_end(ap);
+    if(size == -1) return -1;
     ret = printbuf_memappend(p, t, size);
     free(t);
     return ret;