]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
spi: microchip-core: Fix an error handling path in mchp_corespi_probe()
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Fri, 5 Dec 2025 21:14:10 +0000 (22:14 +0100)
committerMark Brown <broonie@kernel.org>
Tue, 9 Dec 2025 01:01:32 +0000 (10:01 +0900)
mchp_corespi_init() calls mchp_corespi_enable_ints(), so
mchp_corespi_disable_ints() should be called if an error occurs after
calling mchp_corespi_init(), as already done in the remove function.

Fixes: 059f545832be ("spi: add support for microchip "soft" spi controller")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Link: https://patch.msgid.link/a7aaff1f28a83303a288de2914724a874fe1a11e.1764969247.git.christophe.jaillet@wanadoo.fr
Acked-by: Conor Dooley <conor.dooley@microchip.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-microchip-core-spi.c

index 98bf0e6cd00e18df808b8815b33b53286dea842b..89e40fc45d73aa8abbd708c7e1ef24d08860f0d9 100644 (file)
@@ -387,6 +387,7 @@ static int mchp_corespi_probe(struct platform_device *pdev)
 
        ret = devm_spi_register_controller(dev, host);
        if (ret) {
+               mchp_corespi_disable_ints(spi);
                mchp_corespi_disable(spi);
                return dev_err_probe(dev, ret, "unable to register host for CoreSPI controller\n");
        }