]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
mm/damon/tests/core-kunit: handle alloc failures in damon_test_update_monitoring_result()
authorSeongJae Park <sj@kernel.org>
Sat, 1 Nov 2025 18:20:05 +0000 (11:20 -0700)
committerAndrew Morton <akpm@linux-foundation.org>
Mon, 17 Nov 2025 01:28:32 +0000 (17:28 -0800)
damon_test_update_monitoring_result() is assuming all dynamic memory
allocation in it will succeed.  Those are indeed likely in the real use
cases since those allocations are too small to fail, but theoretically
those could fail.  In the case, inappropriate memory access can happen.
Fix it by appropriately cleanup pre-allocated memory and skip the
execution of the remaining tests in the failure cases.

Link: https://lkml.kernel.org/r/20251101182021.74868-12-sj@kernel.org
Fixes: f4c978b6594b ("mm/damon/core-test: add a test for damon_update_monitoring_results()")
Signed-off-by: SeongJae Park <sj@kernel.org>
Cc: Brendan Higgins <brendan.higgins@linux.dev>
Cc: David Gow <davidgow@google.com>
Cc: Kefeng Wang <wangkefeng.wang@huawei.com>
Cc: <stable@vger.kernel.org> [6.3+]
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
mm/damon/tests/core-kunit.h

index e38c95f86a68fecae1bda90dfe7244a62efffaf4..10c9953581eefdd24cfe9c2cfce709caccaacd3d 100644 (file)
@@ -429,6 +429,9 @@ static void damon_test_update_monitoring_result(struct kunit *test)
        struct damon_attrs new_attrs;
        struct damon_region *r = damon_new_region(3, 7);
 
+       if (!r)
+               kunit_skip(test, "region alloc fail");
+
        r->nr_accesses = 15;
        r->nr_accesses_bp = 150000;
        r->age = 20;