plugins: free views that can't load

Trying to use an unloaded view can lead to crashes.
If a view can't be loaded, free it right away.

diff --git a/src/plugins/splash/fade-throbber/plugin.c b/src/plugins/splash/fade-throbber/plugin.c
index 00410dea83f6ab85c3f9afb1963306dc2b05d9b0..aba2cc6213a54d4f499c3e7d97308f4130521d96 100644 (file)
--- a/src/plugins/splash/fade-throbber/plugin.c
+++ b/src/plugins/splash/fade-throbber/plugin.c
@@ -295,8 +295,12 @@ load_views (ply_boot_splash_plugin_t *plugin)
                 view = ply_list_node_get_data (node);
                 next_node = ply_list_get_next_node (plugin->views, node);
 
-                if (view_load (view))
+                if (view_load (view)) {
                         view_loaded = true;
+                } else {
+                        ply_list_remove_node (plugin->views, node);
+                        view_free (view);
+                }
 
                 node = next_node;
         }