]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
kconfig: clear expr::val_is_valid when allocated
authorMasahiro Yamada <masahiroy@kernel.org>
Mon, 30 Sep 2024 17:02:22 +0000 (02:02 +0900)
committerMasahiro Yamada <masahiroy@kernel.org>
Tue, 1 Oct 2024 08:05:30 +0000 (17:05 +0900)
Since commit 95573cac25c6 ("kconfig: cache expression values"), xconfig
emits a lot of false-positive "unmet direct dependencies" warnings.

While conf_read() clears val_is_valid flags, 'make xconfig' calculates
symbol values even before the conf_read() call. This is another issue
that should be addressed separately, but it has revealed that the
val_is_valid field is not initialized.

Fixes: 95573cac25c6 ("kconfig: cache expression values")
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
scripts/kconfig/expr.c

index 78738ef412de2e42ac82eb0718462c2ea7f2e853..16f92c4a775a13f053c636598df70702b8fe7c4d 100644 (file)
@@ -47,6 +47,7 @@ static struct expr *expr_lookup(enum expr_type type, void *l, void *r)
        e->type = type;
        e->left._initdata = l;
        e->right._initdata = r;
+       e->val_is_valid = false;
 
        hash_add(expr_hashtable, &e->node, hash);