]> git.ipfire.org Git - thirdparty/u-boot.git/commitdiff
net: dwc_eth_qos_rockchip: Fix disable of RX/TX delay for RK3588
authorJonas Karlman <jonas@kwiboo.se>
Sun, 9 Feb 2025 23:27:56 +0000 (23:27 +0000)
committerKever Yang <kever.yang@rock-chips.com>
Wed, 19 Feb 2025 15:26:11 +0000 (23:26 +0800)
When rgmii-rxid/txid/id phy-mode is used the MAC should not add RX
and/or TX delay. Currently RX/TX delay is configured as enabled using
zero as delay value for the rgmii-rxid/txid/id modes.

Change to disable RX and/or TX delay and using zero as delay value.

Signed-off-by: Jonas Karlman <jonas@kwiboo.se>
Reviewed-by: Kever Yang <kever.yang@rock-chips.com>
drivers/net/dwc_eth_qos_rockchip.c

index 3e10e07403c103043888b8f94acd118ee05e2a99..f3a0f63003ea1f1f0ccb50bdc31f662be6b1a40e 100644 (file)
@@ -134,6 +134,10 @@ static int rk3568_set_gmac_speed(struct udevice *dev)
        return 0;
 }
 
+#define RK3588_DELAY_ENABLE(id, tx, rx) \
+       (((tx) ? RK3588_GMAC_TXCLK_DLY_ENABLE(id) : RK3588_GMAC_TXCLK_DLY_DISABLE(id)) | \
+        ((rx) ? RK3588_GMAC_RXCLK_DLY_ENABLE(id) : RK3588_GMAC_RXCLK_DLY_DISABLE(id)))
+
 /* sys_grf */
 #define RK3588_GRF_GMAC_CON7                   0x031c
 #define RK3588_GRF_GMAC_CON8                   0x0320
@@ -192,8 +196,7 @@ static int rk3588_set_to_rgmii(struct udevice *dev,
                     RK3588_GMAC_CLK_RGMII_MODE(id));
 
        regmap_write(data->grf, RK3588_GRF_GMAC_CON7,
-                    RK3588_GMAC_RXCLK_DLY_ENABLE(id) |
-                    RK3588_GMAC_TXCLK_DLY_ENABLE(id));
+                    RK3588_DELAY_ENABLE(id, tx_delay, rx_delay));
 
        regmap_write(data->grf, offset_con,
                     RK3588_GMAC_CLK_RX_DL_CFG(rx_delay) |