]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
ALSA: firewire-tascam: fix memory leak of private data
authorTakashi Sakamoto <o-takashi@sakamocchi.jp>
Thu, 13 Sep 2018 12:31:05 +0000 (21:31 +0900)
committerTakashi Iwai <tiwai@suse.de>
Thu, 13 Sep 2018 13:14:39 +0000 (15:14 +0200)
Although private data of sound card instance is usually allocated in the
tail of the instance, drivers in ALSA firewire stack allocate the private
data before allocating the instance. In this case, the private data
should be released explicitly at .private_free callback of the instance.

This commit fixes memory leak following to the above design.

Fixes: b610386c8afb ('ALSA: firewire-tascam: deleyed registration of sound card')
Cc: <stable@vger.kernel.org> # v4.7+
Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/firewire/tascam/tascam.c

index 44ad41fb7374070458de78e991330a744d3f0aff..d3fdc463a884e31e15518f2780c4ca080573a9de 100644 (file)
@@ -93,6 +93,7 @@ static void tscm_free(struct snd_tscm *tscm)
        fw_unit_put(tscm->unit);
 
        mutex_destroy(&tscm->mutex);
+       kfree(tscm);
 }
 
 static void tscm_card_free(struct snd_card *card)