]> git.ipfire.org Git - thirdparty/dracut.git/commitdiff
perf(dracut.sh): do not mkdir $initdir/lib/dracut within a loop
authorAntonio Alvarez Feijoo <antonio.feijoo@suse.com>
Mon, 19 Dec 2022 15:39:46 +0000 (16:39 +0100)
committerJóhann B. Guðmundsson <johannbg@gmail.com>
Wed, 21 Dec 2022 14:14:45 +0000 (14:14 +0000)
This directory is always needed to store files like modules.txt and
build-parameter.txt, so always create it, but only in one place.

dracut.sh

index f6b8a015ae7a7742cb492cb1c56a3b5f46b21a35..793431fa6a7952b3a1222aa1a88e8e4a5260bb0a 100755 (executable)
--- a/dracut.sh
+++ b/dracut.sh
@@ -2010,10 +2010,11 @@ else
     done
 fi
 
+mkdir -p "${initdir}"/lib/dracut
+
 if [[ $kernel_only != yes ]]; then
     mkdir -p "${initdir}/etc/cmdline.d"
-    # shellcheck disable=SC2174
-    mkdir -m 0755 -p "${initdir}"/lib "${initdir}"/lib/dracut "${initdir}"/lib/dracut/hooks
+    mkdir -m 0755 "${initdir}"/lib/dracut/hooks
     # shellcheck disable=SC2154
     for _d in $hookdirs; do
         # shellcheck disable=SC2174
@@ -2071,7 +2072,6 @@ done
 unset moddir
 
 for i in $modules_loaded; do
-    mkdir -p "$initdir"/lib/dracut
     printf "%s\n" "$i" >> "$initdir"/lib/dracut/modules.txt
 done