]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
crypto: tegra - Remove an incorrect iommu_fwspec_free() call in tegra_se_remove()
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Sat, 25 May 2024 15:14:35 +0000 (17:14 +0200)
committerHerbert Xu <herbert@gondor.apana.org.au>
Fri, 31 May 2024 09:34:56 +0000 (17:34 +0800)
The only iommu function call in this driver is a
tegra_dev_iommu_get_stream_id() which does not allocate anything and does
not take any reference.

So there is no point in calling iommu_fwspec_free() in the remove function.

Remove this incorrect function call.

Fixes: 0880bb3b00c8 ("crypto: tegra - Add Tegra Security Engine driver")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Tested-by: Akhil R <akhilrajeev@nvidia.com>
Acked-by: Akhil R <akhilrajeev@nvidia.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
drivers/crypto/tegra/tegra-se-main.c

index 9955874b3dc37d1748491aec758abdfb39535cb7..f94c0331b148cc673e42fbb99843bfce20bc811c 100644 (file)
@@ -326,7 +326,6 @@ static void tegra_se_remove(struct platform_device *pdev)
 
        crypto_engine_stop(se->engine);
        crypto_engine_exit(se->engine);
-       iommu_fwspec_free(se->dev);
        host1x_client_unregister(&se->client);
 }