fuse: Uninitialized variable in fuse_epoch_work()

The fuse_ilookup() function only sets *fm on the success path so this
"if (fm) {" NULL check doesn't work.  The "fm" pointer is either
uninitialized or valid.  Check the "inode" pointer instead.

Also, while it's not necessary, it is cleaner to move the iput(inode)
under the NULL check as well.

Fixes: 64becd224ff9 ("fuse: new work queue to invalidate dentries from old epochs")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Luis Henriques <luis@igalia.com>
Signed-off-by: Miklos Szeredi <mszeredi@redhat.com>

diff --git a/fs/fuse/dir.c b/fs/fuse/dir.c
index 963f53f394c6c28de3dce9c804d48756eb6d4790..2aec225740a072e659e69c30e7dc9a4074580bdf 100644 (file)
--- a/fs/fuse/dir.c
+++ b/fs/fuse/dir.c
@@ -199,9 +199,8 @@ void fuse_epoch_work(struct work_struct *work)
        down_read(&fc->killsb);
 
        inode = fuse_ilookup(fc, FUSE_ROOT_ID, &fm);
-       iput(inode);
-
-       if (fm) {
+       if (inode) {
+               iput(inode);
                /* Remove all possible active references to cached inodes */
                shrink_dcache_sb(fm->sb);
        } else