scsi: st: Tighten the page format heuristics with MODE SELECT

In the days when SCSI-2 was emerging, some drives did claim SCSI-2 but did
not correctly implement it. The st driver first tries MODE SELECT with the
page format bit set to set the block descriptor.  If not successful, the
non-page format is tried.

The test only tests the sense code and this triggers also from illegal
parameter in the parameter list. The test is limited to "old" devices and
made more strict to remove false alarms.

Signed-off-by: Kai Mäkisara <Kai.Makisara@kolumbus.fi>
Link: https://lore.kernel.org/r/20250311112516.5548-4-Kai.Makisara@kolumbus.fi
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

diff --git a/drivers/scsi/st.c b/drivers/scsi/st.c
index fda79758101974c9cedfb1427ad115cae2f068dc..74a6830b7ed8eb6d6d0a385438b9da9a51d65ba8 100644 (file)
--- a/drivers/scsi/st.c
+++ b/drivers/scsi/st.c
@@ -3104,7 +3104,9 @@ static int st_int_ioctl(struct scsi_tape *STp, unsigned int cmd_in, unsigned lon
                           cmd_in == MTSETDRVBUFFER ||
                           cmd_in == SET_DENS_AND_BLK) {
                        if (cmdstatp->sense_hdr.sense_key == ILLEGAL_REQUEST &&
-                           !(STp->use_pf & PF_TESTED)) {
+                               cmdstatp->sense_hdr.asc == 0x24 &&
+                               (STp->device)->scsi_level <= SCSI_2 &&
+                               !(STp->use_pf & PF_TESTED)) {
                                /* Try the other possible state of Page Format if not
                                   already tried */
                                STp->use_pf = (STp->use_pf ^ USE_PF) | PF_TESTED;