]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
KVM: x86/mmu: Put refcounted pages instead of blindly releasing pfns
authorSean Christopherson <seanjc@google.com>
Thu, 10 Oct 2024 18:23:49 +0000 (11:23 -0700)
committerPaolo Bonzini <pbonzini@redhat.com>
Fri, 25 Oct 2024 17:00:47 +0000 (13:00 -0400)
Now that all x86 page fault paths precisely track refcounted pages, use
Use kvm_page_fault.refcounted_page to put references to struct page memory
when finishing page faults.  This is a baby step towards eliminating
kvm_pfn_to_refcounted_page().

Tested-by: Alex Bennée <alex.bennee@linaro.org>
Signed-off-by: Sean Christopherson <seanjc@google.com>
Tested-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <20241010182427.1434605-48-seanjc@google.com>

arch/x86/kvm/mmu/mmu.c

index c657c3c449c87a40e673f5879fa66fbf20d82c43..fe3f3bc0bb79b14f713a42ecf89a1fce0363ce98 100644 (file)
@@ -4380,6 +4380,9 @@ static void kvm_mmu_finish_page_fault(struct kvm_vcpu *vcpu,
        lockdep_assert_once(lockdep_is_held(&vcpu->kvm->mmu_lock) ||
                            r == RET_PF_RETRY);
 
+       if (!fault->refcounted_page)
+               return;
+
        /*
         * If the page that KVM got from the *primary MMU* is writable, and KVM
         * installed or reused a SPTE, mark the page/folio dirty.  Note, this
@@ -4391,9 +4394,9 @@ static void kvm_mmu_finish_page_fault(struct kvm_vcpu *vcpu,
         * folio dirty if KVM could locklessly make the SPTE writable.
         */
        if (!fault->map_writable || r == RET_PF_RETRY)
-               kvm_release_pfn_clean(fault->pfn);
+               kvm_release_page_clean(fault->refcounted_page);
        else
-               kvm_release_pfn_dirty(fault->pfn);
+               kvm_release_page_dirty(fault->refcounted_page);
 }
 
 static int kvm_mmu_faultin_pfn_private(struct kvm_vcpu *vcpu,