]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
perf inject: Fix use without initialization of local variables
authorIan Rogers <irogers@google.com>
Wed, 11 Dec 2024 06:08:31 +0000 (22:08 -0800)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Tue, 14 Jan 2025 17:57:19 +0000 (14:57 -0300)
Local variables were missing initialization and command line
processing didn't provide default values.

Fixes: 64eed019f3fce124 ("perf inject: Lazy build-id mmap2 event insertion")
Reviewed-by: James Clark <james.clark@linaro.org>
Signed-off-by: Ian Rogers <irogers@google.com>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Kan Liang <kan.liang@linux.intel.com>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: https://lore.kernel.org/r/20241211060831.806539-1-irogers@google.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/builtin-inject.c

index d6989195a061ffe589c64ec49e609bb7a866fc29..11e49cafa3af9d82b211d29b1c9123f12b1cddd2 100644 (file)
@@ -2367,10 +2367,10 @@ int cmd_inject(int argc, const char **argv)
        };
        int ret;
        const char *known_build_ids = NULL;
-       bool build_ids;
-       bool build_id_all;
-       bool mmap2_build_ids;
-       bool mmap2_build_id_all;
+       bool build_ids = false;
+       bool build_id_all = false;
+       bool mmap2_build_ids = false;
+       bool mmap2_build_id_all = false;
 
        struct option options[] = {
                OPT_BOOLEAN('b', "build-ids", &build_ids,