]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
drm/amdgpu: Fix build error when CONFIG_SUSPEND is disabled
authorPerry Yuan <perry.yuan@amd.com>
Mon, 7 Jul 2025 02:45:28 +0000 (10:45 +0800)
committerAlex Deucher <alexander.deucher@amd.com>
Mon, 4 Aug 2025 18:26:38 +0000 (14:26 -0400)
The variable `pm_suspend_target_state` is conditionally defined only when
`CONFIG_SUSPEND` is enabled (see `include/linux/suspend.h`). Directly
referencing it without guarding by `#ifdef CONFIG_SUSPEND` causes build
failures when suspend functionality is disabled (e.g., `CONFIG_SUSPEND=n`).

Reviewed-by: Lijo Lazar <lijo.lazar@amd.com>
Signed-off-by: Perry Yuan <perry.yuan@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c

index efb54c23ba173a73cff9797021f7f855c3e72535..8e8b7d2c3f42eefbf722281a9b16a9004aa4825f 100644 (file)
@@ -2597,6 +2597,7 @@ static int amdgpu_pmops_suspend(struct device *dev)
        else if (amdgpu_acpi_is_s3_active(adev))
                adev->in_s3 = true;
        if (!adev->in_s0ix && !adev->in_s3) {
+#if IS_ENABLED(CONFIG_SUSPEND)
                /* don't allow going deep first time followed by s2idle the next time */
                if (adev->last_suspend_state != PM_SUSPEND_ON &&
                    adev->last_suspend_state != pm_suspend_target_state) {
@@ -2604,11 +2605,14 @@ static int amdgpu_pmops_suspend(struct device *dev)
                                     pm_suspend_target_state);
                        return -EINVAL;
                }
+#endif
                return 0;
        }
 
+#if IS_ENABLED(CONFIG_SUSPEND)
        /* cache the state last used for suspend */
        adev->last_suspend_state = pm_suspend_target_state;
+#endif
 
        return amdgpu_device_suspend(drm_dev, true);
 }