config: drop `git_config_get_value()` wrapper

In 036876a1067 (config: hide functions using `the_repository` by
default, 2024-08-13) we have moved around a bunch of functions in the
config subsystem that depend on `the_repository`. Those function have
been converted into mere wrappers around their equivalent function that
takes in a repository as parameter, and the intent was that we'll
eventually remove those wrappers to make the dependency on the global
repository variable explicit at the callsite.

Follow through with that intent and remove `git_config_get_value()`. All
callsites are adjusted so that they use
`repo_config_get_value(the_repository, ...)` instead. While some
callsites might already have a repository available, this mechanical
conversion is the exact same as the current situation and thus cannot
cause any regression. Those sites should eventually be cleaned up in a
later patch series.

Signed-off-by: Patrick Steinhardt <ps@pks.im>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

diff --git a/config.h b/config.h
index 5dc330b88b1ab9e1e5b7f8b0b3570c692f62cd09..e90c1c4d33587f40f43cfd760f886b63ebc3f490 100644 (file)
--- a/config.h
+++ b/config.h
@@ -719,11 +719,6 @@ NORETURN void git_die_config_linenr(const char *key, const char *filename, int l
 int lookup_config(const char **mapping, int nr_mapping, const char *var);
 
 # ifdef USE_THE_REPOSITORY_VARIABLE
-static inline int git_config_get_value_multi(const char *key, const struct string_list **dest)
-{
-       return repo_config_get_value_multi(the_repository, key, dest);
-}
-
 static inline int git_config_get_string_multi(const char *key,
                                const struct string_list **dest)
 {

diff --git a/t/helper/test-config.c b/t/helper/test-config.c
index 99c91512173dfd9a06c912227f7fc3018bd9963b..1953ab846e455a05e81e9adf7671e5855b96ea3c 100644 (file)
--- a/t/helper/test-config.c
+++ b/t/helper/test-config.c
@@ -121,7 +121,7 @@ int cmd__config(int argc, const char **argv)
                        goto exit1;
                }
        } else if (argc == 3 && !strcmp(argv[1], "get_value_multi")) {
-               if (!git_config_get_value_multi(argv[2], &strptr)) {
+               if (!repo_config_get_value_multi(the_repository, argv[2], &strptr)) {
                        for (i = 0; i < strptr->nr; i++) {
                                v = strptr->items[i].string;
                                if (!v)