]> git.ipfire.org Git - thirdparty/qemu.git/commitdiff
openpic_kvm: drop address_space_to_flatview call
authorPaolo Bonzini <pbonzini@redhat.com>
Mon, 5 Mar 2018 08:18:26 +0000 (09:18 +0100)
committerMichael Roth <mdroth@linux.vnet.ibm.com>
Thu, 21 Jun 2018 01:44:59 +0000 (20:44 -0500)
The MemoryListener is registered on address_space_memory, there is
not much to assert.  This currently works because the callback
is invoked only once when the listener is registered, but section->fv
is the _new_ FlatView, not the old one on later calls and that
would break.

This confines address_space_to_flatview to exec.c and memory.c.

Acked-by: David Gibson <david@gibson.dropbear.id.au>
Reviewed-by: Alexey Kardashevskiy <aik@ozlabs.ru>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
(cherry picked from commit 80d2b933f9fe3e53d4f76a45a1bc1a0175669468)
Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
hw/intc/openpic_kvm.c

index fa83420254d8a7e95a6abc162e7d6b4fbb1a57a1..39a6f369c5155aef3a301e4e112df05ebc7bc1c9 100644 (file)
@@ -124,10 +124,6 @@ static void kvm_openpic_region_add(MemoryListener *listener,
     uint64_t reg_base;
     int ret;
 
-    if (section->fv != address_space_to_flatview(&address_space_memory)) {
-        abort();
-    }
-
     /* Ignore events on regions that are not us */
     if (section->mr != &opp->mem) {
         return;